[Snowflake] Unify toolbar text styles

chrome/android/java/res/values/dimens.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 
 <resources>
     <!-- Connection info popup dimensions -->
     <dimen name="connection_info_padding_wide">24dp</dimen>
     <dimen name="connection_info_padding_thin">16dp</dimen>
 
@@ skipping 256 matching lines @@
 
     <dimen name="tablet_toolbar_start_padding">4dp</dimen>
     <dimen name="tablet_toolbar_start_padding_no_buttons">6dp</dimen>
     <dimen name="tablet_toolbar_end_padding">6dp</dimen>
     <dimen name="location_bar_status_separator_width">1dp</dimen>
 
     <!-- Omnibox suggestions -->
     <dimen name="omnibox_suggestion_height">60dp</dimen>
     <dimen name="omnibox_suggestion_answer_height">72dp</dimen>
     <dimen name="omnibox_suggestion_definition_height">95dp</dimen>
-    <dimen name="omnibox_suggestion_list_padding_top">0dp</dimen>
-    <dimen name="omnibox_suggestion_list_padding_bottom">0dp</dimen>
+    <dimen name="omnibox_suggestion_list_padding_top">8dp</dimen>
+    <dimen name="omnibox_suggestion_list_padding_bottom">8dp</dimen>

[Theresa, 2017/06/08 16:12:24]

These also exist in values-sw600dp/dimens.xml; I having trouble tracing the
origins of why we use 0dp here but 8dp in sw600dp for tablets due to upstreaming
a couple of years ago.

+tedchoc@ - do you recall (or know someone who may recall) why the suggestions
padding is different for phones and tablets?

[Ted C, 2017/06/08 16:37:39]

I suspect that dates back to the original material design change in chrome.  I
would guess that the tablet is a dropdown and the phone is a full sheet so maybe
this padding was just unnecessary?  We might end up getting a scrollbar
unnecessarily if it barely just fit where the padding overflows past the
keyboard.

If we have screenshots with 1 suggestion and a full set of suggestions, and ux
signs off on it, then they've updated their specs.

Legacy code review.
https://chrome-internal-review.googlesource.com/c/172055/

     <dimen name="omnibox_suggestion_first_line_text_size">16sp</dimen>
     <dimen name="omnibox_suggestion_second_line_text_size">14sp</dimen>
     <dimen name="omnibox_suggestion_answer_line2_vertical_spacing">3dp</dimen>
     <!-- omnibox_suggestion_answer_line2_vertical_spacing + 2dp -->
     <dimen name="omnibox_suggestion_answer_image_vertical_spacing">5dp</dimen>
     <dimen name="omnibox_suggestion_answer_image_horizontal_spacing">4dp</dimen>
     <dimen name="omnibox_suggestion_phone_url_bar_left_offset">10dp</dimen>
     <dimen name="omnibox_suggestion_phone_url_bar_left_offset_rtl">46dp</dimen>
     <dimen name="omnibox_suggestion_refine_width">48dp</dimen>
     <dimen name="omnibox_suggestion_text_vertical_padding">5dp</dimen>
@@ skipping 183 matching lines @@
     <dimen name="context_menu_header_image_min_size">56dp</dimen>
     <dimen name="context_menu_header_image_max_size">56dp</dimen>
 
     <!-- Divider Dimensions -->
     <dimen name="divider_height">1dp</dimen>
 
     <!-- Search widget dimensions -->
     <dimen name="search_activity_location_bar_margin_start">16dp</dimen>
     <dimen name="search_activity_location_bar_margin_end">8dp</dimen>
 </resources>