Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2930703003: Extensions: Support forIOThread function schema attribute for IDL files. (Closed)

Created:
3 years, 6 months ago by karandeepb
Modified:
3 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Extensions: Support forIOThread function schema attribute for IDL files. r477384 added support for specifying IOThread extension functions in schemas using the 'forIOThread' attribute. This CL adds support for the same to IDL files. BUG=None Review-Url: https://codereview.chromium.org/2930703003 Cr-Commit-Position: refs/heads/master@{#478438} Committed: https://chromium.googlesource.com/chromium/src/+/4205adf118e0412635c2de35800e3265817a2963

Patch Set 1 #

Patch Set 2 : -- #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M tools/json_schema_compiler/idl_schema.py View 1 1 chunk +8 lines, -5 lines 0 comments Download
M tools/json_schema_compiler/idl_schema_test.py View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/test/idl_basics.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
karandeepb
PTAL Devlin.
3 years, 6 months ago (2017-06-08 18:29:22 UTC) #7
Devlin
lgtm; nice!
3 years, 6 months ago (2017-06-09 20:36:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930703003/20001
3 years, 6 months ago (2017-06-09 20:44:19 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 22:45:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4205adf118e0412635c2de35800e...

Powered by Google App Engine
This is Rietveld 408576698