Update a comment in network time test helper

Update a comment in network time test helper

BUG=684216
Review-Url: https://codereview.chromium.org/2930613002
Cr-Commit-Position: refs/heads/master@{#478031}
Committed: https://chromium.googlesource.com/chromium/src/+/f397511c435587def5e9d55a2d26a23324f89956

[estark, 2017-06-07 05:11:58]

estark@chromium.org changed reviewers:
+ meacer@chromium.org

[estark, 2017-06-07 05:11:58]

meacer, PTAL? Thanks!

[meacer, 2017-06-07 17:29:21]

Lgtm

https://codereview.chromium.org/2930613002/diff/1/components/network_time/net...
File components/network_time/network_time_test_utils.cc (right):

https://codereview.chromium.org/2930613002/diff/1/components/network_time/net...
components/network_time/network_time_test_utils.cc:104: // one.
nit: Would it make sense to mention the alternative as well? (remove
SetNetworkQueriesWithVariationsService from here and call it separately in each
test)

[estark, 2017-06-08 17:35:24]

On 2017/06/07 17:29:21, meacer wrote:
> Lgtm
> 
>
https://codereview.chromium.org/2930613002/diff/1/components/network_time/net...
> File components/network_time/network_time_test_utils.cc (right):
> 
>
https://codereview.chromium.org/2930613002/diff/1/components/network_time/net...
> components/network_time/network_time_test_utils.cc:104: // one.
> nit: Would it make sense to mention the alternative as well? (remove
> SetNetworkQueriesWithVariationsService from here and call it separately in
each
> test)

Tried it out but to me it gets confusing to have that in the comment. I added a
link to your comment in the bug so that if anyone's curious they can go read it.

[estark, 2017-06-08 17:35:40]

The CQ bit was checked by estark@chromium.org

[estark, 2017-06-08 17:35:41]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2930613002/#ps20001
(title: "add link to bug discussion")

[commit-bot: I haz the power, 2017-06-08 17:36:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meacer, 2017-06-08 18:00:39]

On 2017/06/08 17:35:24, estark (slow thru Jun8) wrote:
> On 2017/06/07 17:29:21, meacer wrote:
> > Lgtm
> > 
> >
>
https://codereview.chromium.org/2930613002/diff/1/components/network_time/net...
> > File components/network_time/network_time_test_utils.cc (right):
> > 
> >
>
https://codereview.chromium.org/2930613002/diff/1/components/network_time/net...
> > components/network_time/network_time_test_utils.cc:104: // one.
> > nit: Would it make sense to mention the alternative as well? (remove
> > SetNetworkQueriesWithVariationsService from here and call it separately in
> each
> > test)
> 
> Tried it out but to me it gets confusing to have that in the comment. I added
a
> link to your comment in the bug so that if anyone's curious they can go read
it.

SG, thanks.

[commit-bot: I haz the power, 2017-06-08 18:29:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496943340666280,
"parent_rev": "b52a2dfadb3158e39a3848d3631a2deffd4b2ac8", "commit_rev":
"f397511c435587def5e9d55a2d26a23324f89956"}

[commit-bot: I haz the power, 2017-06-08 18:29:16]

Description was changed from

==========
Update a comment in network time test helper

BUG=684216
==========

to

==========
Update a comment in network time test helper

BUG=684216

Review-Url: https://codereview.chromium.org/2930613002
Cr-Commit-Position: refs/heads/master@{#478031}
Committed:
https://chromium.googlesource.com/chromium/src/+/f397511c435587def5e9d55a2d26...
==========

[commit-bot: I haz the power, 2017-06-08 18:29:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f397511c435587def5e9d55a2d26...