Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2930583002: Add Foreground-to-FirstMeaningfulPaint histogram (Closed)

Created:
3 years, 6 months ago by Kunihiko Sakamoto
Modified:
3 years, 6 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, asvitkine+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Foreground-to-FirstMeaningfulPaint histogram This metric measures the time between background tab being foregrounded and the first meaningful paint. This would help to understand the impact of loading request throttling for background tabs. BUG=729951 Review-Url: https://codereview.chromium.org/2930583002 Cr-Commit-Position: refs/heads/master@{#478166} Committed: https://chromium.googlesource.com/chromium/src/+/aa319f6ec07a46c2e9d0b56bb22baad5e407c939

Patch Set 1 #

Total comments: 2

Patch Set 2 : utility function #

Patch Set 3 : add FCP variant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -10 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 1 2 4 chunks +20 lines, -10 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_util.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_util.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
Kunihiko Sakamoto
3 years, 6 months ago (2017-06-07 07:45:35 UTC) #8
Takashi Toyoshima
lg with one suggestion https://codereview.chromium.org/2930583002/diff/20001/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc File chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc (right): https://codereview.chromium.org/2930583002/diff/20001/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc#newcode502 chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc:502: // Record the time to ...
3 years, 6 months ago (2017-06-07 08:39:38 UTC) #9
Kunihiko Sakamoto
+bmcquade@ for page_load_metrics +isherman@ for histograms.xml PTAL https://codereview.chromium.org/2930583002/diff/20001/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc File chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc (right): https://codereview.chromium.org/2930583002/diff/20001/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc#newcode502 chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc:502: // Record ...
3 years, 6 months ago (2017-06-07 09:20:52 UTC) #11
kinuko
Non-real-reviewer lgtm, cool!
3 years, 6 months ago (2017-06-07 09:45:35 UTC) #12
tdresser
Could we add an FCP variant as well?
3 years, 6 months ago (2017-06-07 12:19:05 UTC) #14
Bryan McQuade
On 2017/06/07 at 12:19:05, tdresser wrote: > Could we add an FCP variant as well? ...
3 years, 6 months ago (2017-06-07 13:55:18 UTC) #15
Ilya Sherman
Metrics LGTM
3 years, 6 months ago (2017-06-07 21:09:38 UTC) #16
Kunihiko Sakamoto
On 2017/06/07 12:19:05, tdresser wrote: > Could we add an FCP variant as well? OK, ...
3 years, 6 months ago (2017-06-08 03:36:41 UTC) #19
Ilya Sherman
(Metrics still LGTM)
3 years, 6 months ago (2017-06-08 03:53:42 UTC) #20
Kunihiko Sakamoto
Kinuko-san, PTAL for PS 2 to 3 change, which is simple addition of FG-to-FCP histogram.
3 years, 6 months ago (2017-06-08 04:46:09 UTC) #21
kinuko
lgtm!
3 years, 6 months ago (2017-06-09 02:25:26 UTC) #24
kinuko
lgtm
3 years, 6 months ago (2017-06-09 02:25:32 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930583002/60001
3 years, 6 months ago (2017-06-09 02:28:21 UTC) #28
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 02:32:53 UTC) #31
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/aa319f6ec07a46c2e9d0b56bb22b...

Powered by Google App Engine
This is Rietveld 408576698