Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2930573005: Use ContainsValue() instead of std::find() in ui/android, ui/base and ui/views (Closed)

Created:
3 years, 6 months ago by Tripta
Modified:
3 years, 6 months ago
Reviewers:
a.suchit, sadrul, sadrul-g
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, shuchen+watch_chromium.org, dcheng, nona+watch_chromium.org, oshima+watch_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContainsValue() instead of std::find() in ui/android, ui/base and ui/views BUG=561800 Review-Url: https://codereview.chromium.org/2930573005 Cr-Commit-Position: refs/heads/master@{#478558} Committed: https://chromium.googlesource.com/chromium/src/+/e43c9f5c05c4d6a929907441388882a8f1795b46

Patch Set 1 #

Patch Set 2 : Removed #include <algorithm> from clipboard.cc #

Total comments: 2

Patch Set 3 : Changed EXPECT_FALSE to EXPECT_TRUE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -32 lines) Patch
M ui/android/view_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/accelerators/accelerator_manager.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ui/base/clipboard/clipboard.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download
M ui/base/ime/chromeos/character_composer_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/models/list_selection_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/base/x/selection_utils.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/base/x/x11_util.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/views/layout/grid_layout.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Tripta
Please review the code changes.
3 years, 6 months ago (2017-06-08 11:40:46 UTC) #3
Tripta
Please review the code changes. Regards Tripta
3 years, 6 months ago (2017-06-09 10:16:52 UTC) #5
sadrul
lgtm https://codereview.chromium.org/2930573005/diff/20001/ui/base/ime/chromeos/character_composer_unittest.cc File ui/base/ime/chromeos/character_composer_unittest.cc (right): https://codereview.chromium.org/2930573005/diff/20001/ui/base/ime/chromeos/character_composer_unittest.cc#newcode253 ui/base/ime/chromeos/character_composer_unittest.cc:253: EXPECT_FALSE(!base::ContainsValue(subtrees, value)) << index; EXPECT_TRUE(base::ContainsValue()) instead?
3 years, 6 months ago (2017-06-12 02:05:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930573005/40001
3 years, 6 months ago (2017-06-12 05:05:14 UTC) #9
Tripta
Have changed EXPECT_FALSE to EXPECT_TRUE. Thanks Tripta https://codereview.chromium.org/2930573005/diff/20001/ui/base/ime/chromeos/character_composer_unittest.cc File ui/base/ime/chromeos/character_composer_unittest.cc (right): https://codereview.chromium.org/2930573005/diff/20001/ui/base/ime/chromeos/character_composer_unittest.cc#newcode253 ui/base/ime/chromeos/character_composer_unittest.cc:253: EXPECT_FALSE(!base::ContainsValue(subtrees, value)) ...
3 years, 6 months ago (2017-06-12 05:07:51 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 06:18:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e43c9f5c05c4d6a9299074413888...

Powered by Google App Engine
This is Rietveld 408576698