Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2930573002: [Merge to M60] Use MANUAL arming policy for WebDataConsumerHandleImpl (Closed)

Created:
3 years, 6 months ago by shimazu
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Merge to M60] Use MANUAL arming policy for WebDataConsumerHandleImpl OnHandleGotReadable was possible not to call Read. It triggers sudden re-arming and hogging the CPU. This patch is to avoid the situation by using MANUAL policy. Bug: 728013 Change-Id: Ie6bd7f78806d5b136dc302306cc9e920cdd01c92 Reviewed-on: https://chromium-review.googlesource.com/522144 Reviewed-by: Yutaka Hirano <yhirano@chromium.org>; Reviewed-by: Ken Rockot <rockot@chromium.org>; Commit-Queue: Makoto Shimazu <shimazu@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#477242} Review-Url: https://codereview.chromium.org/2930573002 . Cr-Commit-Position: refs/branch-heads/3112@{#215} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/94340a4f92ed3b97655dd738151b41cb369678c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -1 line) Patch
M content/child/web_data_consumer_handle_impl.cc View 4 chunks +6 lines, -1 line 0 comments Download
M content/child/web_data_consumer_handle_impl_unittest.cc View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shimazu
3 years, 6 months ago (2017-06-07 02:02:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94340a4f92ed3b97655dd738151b41cb369678c0.

Powered by Google App Engine
This is Rietveld 408576698