Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2930543002: [remoting start-host] Make --name optional, and other tweaks. (Closed)

Created:
3 years, 6 months ago by Lambros
Modified:
3 years, 6 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting start-host] Make --name optional, and other tweaks. If --name is omitted, this prompts for a name. If (and only if) --code is omitted, this prints an authorization URL which can be used to obtain a code. This prints a help/usage message if the command includes non-option parameters, or includes a standard option for requesting help. BUG=730097 Review-Url: https://codereview.chromium.org/2930543002 Cr-Commit-Position: refs/heads/master@{#477479} Committed: https://chromium.googlesource.com/chromium/src/+/1b543c74b893c362d0fd2c459a51a3c668535d9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M remoting/host/setup/start_host_main.cc View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lambros
3 years, 6 months ago (2017-06-06 21:53:16 UTC) #2
Jamie
lgtm
3 years, 6 months ago (2017-06-06 23:54:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930543002/1
3 years, 6 months ago (2017-06-06 23:55:30 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 00:21:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1b543c74b893c362d0fd2c459a51...

Powered by Google App Engine
This is Rietveld 408576698