Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: mojo/edk/system/handle_table.h

Issue 2930533003: Minor fixes to Mojo MemoryDumpProvider. (Closed)
Patch Set: comments from ssid. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/core.cc ('k') | mojo/edk/system/handle_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/handle_table.h
diff --git a/mojo/edk/system/handle_table.h b/mojo/edk/system/handle_table.h
index 62c5add0d35dd92412bea7bda1f75a7ea2112996..38741b06bb9843a82827d2cd254467bfd44ec0f6 100644
--- a/mojo/edk/system/handle_table.h
+++ b/mojo/edk/system/handle_table.h
@@ -10,16 +10,19 @@
#include <vector>
#include "base/containers/hash_tables.h"
+#include "base/gtest_prod_util.h"
#include "base/macros.h"
#include "base/synchronization/lock.h"
#include "base/trace_event/memory_dump_provider.h"
#include "mojo/edk/system/dispatcher.h"
+#include "mojo/edk/system/system_impl_export.h"
#include "mojo/public/c/system/types.h"
namespace mojo {
namespace edk {
-class HandleTable : public base::trace_event::MemoryDumpProvider {
+class MOJO_SYSTEM_IMPL_EXPORT HandleTable
+ : public base::trace_event::MemoryDumpProvider {
public:
HandleTable();
~HandleTable() override;
@@ -55,6 +58,8 @@ class HandleTable : public base::trace_event::MemoryDumpProvider {
void GetActiveHandlesForTest(std::vector<MojoHandle> *handles);
private:
+ FRIEND_TEST_ALL_PREFIXES(HandleTableTest, OnMemoryDump);
+
// MemoryDumpProvider implementation.
bool OnMemoryDump(const base::trace_event::MemoryDumpArgs& args,
base::trace_event::ProcessMemoryDump* pmd) override;
« no previous file with comments | « mojo/edk/system/core.cc ('k') | mojo/edk/system/handle_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698