Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: mojo/edk/system/handle_table.cc

Issue 2930533003: Minor fixes to Mojo MemoryDumpProvider. (Closed)
Patch Set: comments from ssid. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/handle_table.h ('k') | mojo/edk/system/handle_table_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/handle_table.cc
diff --git a/mojo/edk/system/handle_table.cc b/mojo/edk/system/handle_table.cc
index d4793bb1855257f93b7ca5fa7385a607eb684b8a..5a9d87da904f78809a88999b29c04a3e0a530fd1 100644
--- a/mojo/edk/system/handle_table.cc
+++ b/mojo/edk/system/handle_table.cc
@@ -32,21 +32,16 @@ const char* GetNameForDispatcherType(Dispatcher::Type type) {
case Dispatcher::Type::PLATFORM_HANDLE:
return "platform_handle";
}
+ NOTREACHED();
return "unknown";
}
-const char* kDumpProviderName = "MojoHandleTable";
-
} // namespace
HandleTable::HandleTable() {
- base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- this, kDumpProviderName, nullptr);
}
HandleTable::~HandleTable() {
- base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
- this, kDumpProviderName, nullptr);
}
base::Lock& HandleTable::GetLock() {
@@ -181,7 +176,6 @@ bool HandleTable::OnMemoryDump(const base::trace_event::MemoryDumpArgs& args,
}
}
- pmd->CreateAllocatorDump("mojo");
for (const auto& entry : handle_count) {
base::trace_event::MemoryAllocatorDump* inner_dump =
pmd->CreateAllocatorDump(std::string("mojo/") +
« no previous file with comments | « mojo/edk/system/handle_table.h ('k') | mojo/edk/system/handle_table_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698