Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2930493002: Add CompositorTouchAction to RuntimeEnabledFeatures. (Closed)

Created:
3 years, 6 months ago by sunxd
Modified:
3 years, 6 months ago
Reviewers:
flackr, xidachen, kinuko
CC:
chromium-reviews, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CompositorTouchAction to RuntimeEnabledFeatures. We are now working on handling touch actions in cc, adding the runtime enabled features would make it possible for the two logics (main thread only and both main thread and cc) to co-exist. The flag will also be useful when we lauch the feature in the future. BUG=727839 Review-Url: https://codereview.chromium.org/2930493002 Cr-Commit-Position: refs/heads/master@{#478026} Committed: https://chromium.googlesource.com/chromium/src/+/4d6bb36e3fcfb9742b6428e43a8e5df12681d0d0

Patch Set 1 #

Patch Set 2 : make the feature not experimental #

Patch Set 3 : Rebase - all the set functions are now capitalized #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M content/child/runtime_features.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebRuntimeFeatures.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
sunxd
Hi Xida, I tried adding the flag with reference to https://www.chromium.org/blink/runtime-enabled-features. But not sure if ...
3 years, 6 months ago (2017-06-06 17:50:40 UTC) #5
xidachen
On 2017/06/06 17:50:40, sunxd wrote: > Hi Xida, > > I tried adding the flag ...
3 years, 6 months ago (2017-06-06 18:23:21 UTC) #6
sunxd
Hi flackr@, Can you take a look at this patch before I ask the owner ...
3 years, 6 months ago (2017-06-06 18:27:04 UTC) #9
flackr
lgtm
3 years, 6 months ago (2017-06-07 18:22:58 UTC) #10
sunxd
Hi kinuko@? Can you please review this patch? We want to implement handling touch actions ...
3 years, 6 months ago (2017-06-07 18:59:43 UTC) #13
kinuko
lgtm
3 years, 6 months ago (2017-06-08 04:56:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930493002/20001
3 years, 6 months ago (2017-06-08 04:56:28 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/437131)
3 years, 6 months ago (2017-06-08 05:06:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930493002/40001
3 years, 6 months ago (2017-06-08 15:45:57 UTC) #21
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 18:17:24 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4d6bb36e3fcfb9742b6428e43a8e...

Powered by Google App Engine
This is Rietveld 408576698