Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2930483002: swarming: Don't normalize .apk files (breaks alignment) (Closed)

Created:
3 years, 6 months ago by agrieve
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

swarming: Don't normalize .apk files (breaks alignment) The normalization is no longer necessary, as ninja now generates .apk files with zeroed out timestamps. The normalization turned out to be actively harmful, as it was not maintaining alignment of zip entries. BUG=729059 Review-Url: https://codereview.chromium.org/2930483002 Cr-Commit-Position: refs/heads/master@{#477372} Committed: https://chromium.googlesource.com/chromium/src/+/28d5fba595834d633f36b0613ecdd7300a10f267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/determinism/remove_build_metadata.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
agrieve
3 years, 6 months ago (2017-06-06 15:26:55 UTC) #2
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-06 16:50:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930483002/1
3 years, 6 months ago (2017-06-06 19:23:07 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 19:29:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28d5fba595834d633f36b0613ecd...

Powered by Google App Engine
This is Rietveld 408576698