Show confirmation dialog when copy/move operation affect other members.

Show confirmation dialog when copy/move operation affect other members.

User can change expose new files to another member or remove files that
was visible for other members in the Files app by these operations:
- Move files from a Team Drive to My Drive
- Move/Copy files from My Drive to a Team Drive
- Move/Copy files from a Team Drive to another Team Drive
- Move files from a Team Drive to Downloads
- Move/Copy files from Downloads to a Team Drive
We'll show a confirmation dialog box before executing such operation, so
that user can either choose to continue or cancel the operation after
knowing what will happen.

BUG=722324
TEST=manually tested by moving/copying files between different Team Drive/My Drive/Downloads
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2930443002
Cr-Commit-Position: refs/heads/master@{#478610}
Committed: https://chromium.googlesource.com/chromium/src/+/63f99bb69d83795394a801343c3827de017ecbbb

[yamaguchi, 2017-06-06 11:20:31]

Description was changed from

==========
Show confirmation dialog when copy/move operation affect other members.

BUG=722324
==========

to

==========
Show confirmation dialog when copy/move operation affect other members.

BUG=722324
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-06-08 13:20:38]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 13:20:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 13:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 13:22:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yamaguchi, 2017-06-08 13:42:34]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 13:42:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-06-08 13:44:29]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 13:44:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-06-08 14:05:07]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 14:05:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-06-08 14:11:38]

yamaguchi@chromium.org changed reviewers:
+ fukino@chromium.org

[yamaguchi, 2017-06-08 14:11:39]

https://codereview.chromium.org/2930443002/diff/110001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp (right):

https://codereview.chromium.org/2930443002/diff/110001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:265:
'ui/compiled_resources2.gyp:file_manager_ui',
I wondered either UI or file_transfer_controller should own the ActionType enum.
I made this way because file_transfer_controllers depnds on ui/* more than
ui/file_manager_ui depends on files in this directory.

https://codereview.chromium.org/2930443002/diff/110001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/2930443002/diff/110001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:574: * @param
{!FileManagerUI.ActionType} type Type of the operation.
This could be a single boolean like "isMove", but for future extension like
adding another type of alert box which only have "OK" button.

[yamaguchi, 2017-06-08 14:12:23]

Description was changed from

==========
Show confirmation dialog when copy/move operation affect other members.

BUG=722324
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Show confirmation dialog when copy/move operation affect other members.

BUG=722324
TEST=manually tested by moving/copying files between different Team Drive/My
Drive/Downloads
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-06-09 07:05:46]

Could you explain what changed and why in the bug description?

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:269: *
@return {!Promise<{title: string, body: !Array<string>}>} Resolves to null if
The returned value and the method description sounds a bit inconsistent to me.
Can we separate it to following two method?
1) Check whether the user's confirmation is necessary.
  Alternatively, you can design enums like following:
    CONFIRMATION_NONE
    CONFIRMATION_COPY_OTHERS_TO_TD
    CONFIRMATION_MOVE_TD_TO_TD
    CONFIRMATION_MOVE_TD_TO_OTHERS
    CONFIRMATION_MOVE_OTHERS_TO_TD

2) Get the information (label etc..) to construct the dialog UI.

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:288: //
Unknown type of destination location. Allow without confirmation for
I think we should abort paste operation (and output console.error) when
this.volumeManager_.getLocationInfo(destinationEntry) returns null.

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:341: if
(!title) {
"Confirmation is unnecessary when title is falsy value" is hard to interpret...

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:645:
clipboardData.getData('fs/sources').split('\n') :
Was this line break forced by presubmit?

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:580:
FileManagerUI.prototype.confirmationHandler = function(
nit: As this is a method, lets start from verbs, like showConfirmationDialog,
handleConfirmation, etc...

[yamaguchi, 2017-06-09 09:09:49]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 09:09:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-06-09 09:17:51]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 09:18:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-06-09 09:49:15]

https://codereview.chromium.org/2930443002/diff/150001/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
(right):

https://codereview.chromium.org/2930443002/diff/150001/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc:115:
SET_STRING("DRIVE_CONFIRM_MOVE_FROM_TEAM_DRIVE_TITLE",
FYI: This was a duplicate.

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:269: *
@return {!Promise<{title: string, body: !Array<string>}>} Resolves to null if
On 2017/06/09 07:05:46, fukino wrote:
> The returned value and the method description sounds a bit inconsistent to me.
> Can we separate it to following two method?
> 1) Check whether the user's confirmation is necessary.
>   Alternatively, you can design enums like following:
>     CONFIRMATION_NONE
>     CONFIRMATION_COPY_OTHERS_TO_TD
>     CONFIRMATION_MOVE_TD_TO_TD
>     CONFIRMATION_MOVE_TD_TO_OTHERS
>     CONFIRMATION_MOVE_OTHERS_TO_TD
> 
> 2) Get the information (label etc..) to construct the dialog UI.

Done.

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:288: //
Unknown type of destination location. Allow without confirmation for
On 2017/06/09 07:05:46, fukino wrote:
> I think we should abort paste operation (and output console.error) when
> this.volumeManager_.getLocationInfo(destinationEntry) returns null.

Done.

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:341: if
(!title) {
On 2017/06/09 07:05:46, fukino wrote:
> "Confirmation is unnecessary when title is falsy value" is hard to
interpret... 

Revised to use NONE enum value.

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:645:
clipboardData.getData('fs/sources').split('\n') :
On 2017/06/09 07:05:46, fukino wrote:
> Was this line break forced by presubmit?

No, I had just overlooked it.

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/2930443002/diff/150001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:580:
FileManagerUI.prototype.confirmationHandler = function(
On 2017/06/09 07:05:46, fukino wrote:
> nit: As this is a method, lets start from verbs, like showConfirmationDialog,
> handleConfirmation, etc...

Done.

[yamaguchi, 2017-06-09 10:00:17]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 10:00:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-06-09 10:23:01]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 10:23:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-06-09 10:24:48]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 10:24:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-06-09 10:25:20]

ptal

https://codereview.chromium.org/2930443002/diff/210001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/2930443002/diff/210001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:692:
console.error('Source entry set was emtpy while attempting to paste.');
I've found this can happen by usual operation. I added comment and made this
handled consistently with another case like "moving a file to the same
directory".

[yamaguchi, 2017-06-09 10:36:11]

Description was changed from

==========
Show confirmation dialog when copy/move operation affect other members.

BUG=722324
TEST=manually tested by moving/copying files between different Team Drive/My
Drive/Downloads
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Show confirmation dialog when copy/move operation affect other members.

User can change expose new files to another member or remove files that
was visible for other members in the Files app by these operations:
- Move files from a Team Drive to My Drive
- Move/Copy files from My Drive to a Team Drive
- Move/Copy files from a Team Drive to another Team Drive
- Move files from a Team Drive to Downloads
- Move/Copy files from Downloads to a Team Drive
We'll show a confirmation dialog box before executing such operation, so
that user can either choose to continue or cancel the operation after
knowing what will happen.

BUG=722324
TEST=manually tested by moving/copying files between different Team Drive/My
Drive/Downloads
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-06-09 11:06:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 11:06:54]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-06-12 08:03:29]

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:274:
MOVE_FROM_TEAM_DRIVE: 'move_from_team_drive',
These enums don't look either disjoint nor exhaustive.
Does MOVE_TO_TEAM_DRIVE includes a move from Team Drive to Team Drive?
Does COPY_TO_TEAM_DRIVE includes a copy from Team Drive to Team Drive?

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:301: if
(destination.isTeamDrive &&
optional nit: I would write this as follows to explicitly explain when the
confirmation dialog is not required:

if (source.isTeamDrive)
  if (destination.isTeamDrive)
    if (source.teamDriveName == destination.teamDriveName)
      NONE
    else
      MOVE_BETWEEN_TEAM_DRIVE
  else
    MOVE_FROM_TEAM_DRIVE
else
  if (destination.isTeamDrive)
    MOVE_TO_TEAM_DRIVE
  else
    NONE

(ditto for copy)

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:322: *
Judges whether the planned operation requires user's confirmation.
Fix the annotation.

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:691: if
(sourceEntries.length <= 0) {
nit: == 0

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:344:
FileManagerUI.ActionType = {
FileOperationType should be more straightforward?

If no other file operation type is in mind, maybe boolean is sufficient, since
we already use isMove other parts in both JS and C++.

If you are thinking of using the same confirmation dialog to other operations
(like share), ConfirmationDialogType might sounds better.

[yamaguchi, 2017-06-12 10:35:23]

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:274:
MOVE_FROM_TEAM_DRIVE: 'move_from_team_drive',
On 2017/06/12 08:03:28, fukino wrote:
> These enums don't look either disjoint nor exhaustive.
> Does MOVE_TO_TEAM_DRIVE includes a move from Team Drive to Team Drive?
> Does COPY_TO_TEAM_DRIVE includes a copy from Team Drive to Team Drive?

Done.

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:301: if
(destination.isTeamDrive &&
On 2017/06/12 08:03:28, fukino wrote:
> optional nit: I would write this as follows to explicitly explain when the
> confirmation dialog is not required:
> 
> if (source.isTeamDrive)
>   if (destination.isTeamDrive)
>     if (source.teamDriveName == destination.teamDriveName)
>       NONE
>     else
>       MOVE_BETWEEN_TEAM_DRIVE
>   else
>     MOVE_FROM_TEAM_DRIVE
> else
>   if (destination.isTeamDrive)
>     MOVE_TO_TEAM_DRIVE
>   else
>     NONE
> 
> (ditto for copy)

Done.

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:322: *
Judges whether the planned operation requires user's confirmation.
On 2017/06/12 08:03:28, fukino wrote:
> Fix the annotation.

Done.

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:691: if
(sourceEntries.length <= 0) {
On 2017/06/12 08:03:29, fukino wrote:
> nit: == 0

Done.

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/2930443002/diff/230001/ui/file_manager/file_m...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:344:
FileManagerUI.ActionType = {
On 2017/06/12 08:03:29, fukino wrote:
> FileOperationType should be more straightforward?
> 
> If no other file operation type is in mind, maybe boolean is sufficient, since
> we already use isMove other parts in both JS and C++.
> 
> If you are thinking of using the same confirmation dialog to other operations
> (like share), ConfirmationDialogType might sounds better.

Changed it to boolean as it'd be enough for now.

https://codereview.chromium.org/2930443002/diff/250001/chrome/app/chromeos_st...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2930443002/diff/250001/chrome/app/chromeos_st...
chrome/app/chromeos_strings.grdp:85: <message
name="IDS_FILE_BROWSER_DRIVE_CONFIRM_MOVE_TO_TEAM_DRIVE_BODY" desc="Part of
message in the confirmation dialog box when moving or copying files into a Team
Drive.">
Should we also change these IDS_* message names mode describes the actual text,
like *_DRIVE_CONFIRM_GAIN_ACCESS ?

[fukino, 2017-06-12 10:41:59]

LGTM. Thanks!

https://codereview.chromium.org/2930443002/diff/250001/chrome/app/chromeos_st...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2930443002/diff/250001/chrome/app/chromeos_st...
chrome/app/chromeos_strings.grdp:85: <message
name="IDS_FILE_BROWSER_DRIVE_CONFIRM_MOVE_TO_TEAM_DRIVE_BODY" desc="Part of
message in the confirmation dialog box when moving or copying files into a Team
Drive.">
On 2017/06/12 10:35:23, yamaguchi wrote:
> Should we also change these IDS_* message names mode describes the actual
text,
> like *_DRIVE_CONFIRM_GAIN_ACCESS ?

It's OK if the ID name describes the message content itself.

[yamaguchi, 2017-06-12 13:45:27]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 13:45:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-06-12 13:46:47]

The CQ bit was unchecked by yamaguchi@chromium.org

[yamaguchi, 2017-06-12 13:48:46]

The CQ bit was checked by yamaguchi@chromium.org

[yamaguchi, 2017-06-12 13:48:46]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2930443002/#ps270001
(title: "Update message resource names.")

[commit-bot: I haz the power, 2017-06-12 13:49:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 14:18:18]

CQ is committing da patch.

Bot data: {"patchset_id": 270001, "attempt_start_ts": 1497275326210890,
"parent_rev": "e123c9108586cd8386edf8df90af739ce84ae3a4", "commit_rev":
"63f99bb69d83795394a801343c3827de017ecbbb"}

[commit-bot: I haz the power, 2017-06-12 14:18:37]

Description was changed from

==========
Show confirmation dialog when copy/move operation affect other members.

User can change expose new files to another member or remove files that
was visible for other members in the Files app by these operations:
- Move files from a Team Drive to My Drive
- Move/Copy files from My Drive to a Team Drive
- Move/Copy files from a Team Drive to another Team Drive
- Move files from a Team Drive to Downloads
- Move/Copy files from Downloads to a Team Drive
We'll show a confirmation dialog box before executing such operation, so
that user can either choose to continue or cancel the operation after
knowing what will happen.

BUG=722324
TEST=manually tested by moving/copying files between different Team Drive/My
Drive/Downloads
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Show confirmation dialog when copy/move operation affect other members.

User can change expose new files to another member or remove files that
was visible for other members in the Files app by these operations:
- Move files from a Team Drive to My Drive
- Move/Copy files from My Drive to a Team Drive
- Move/Copy files from a Team Drive to another Team Drive
- Move files from a Team Drive to Downloads
- Move/Copy files from Downloads to a Team Drive
We'll show a confirmation dialog box before executing such operation, so
that user can either choose to continue or cancel the operation after
knowing what will happen.

BUG=722324
TEST=manually tested by moving/copying files between different Team Drive/My
Drive/Downloads
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2930443002
Cr-Commit-Position: refs/heads/master@{#478610}
Committed:
https://chromium.googlesource.com/chromium/src/+/63f99bb69d83795394a801343c38...
==========

[commit-bot: I haz the power, 2017-06-12 14:18:38]

Committed patchset #15 (id:270001) as
https://chromium.googlesource.com/chromium/src/+/63f99bb69d83795394a801343c38...

[yamaguchi, 2017-06-14 11:24:04]

https://codereview.chromium.org/2930443002/diff/250001/chrome/app/chromeos_st...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2930443002/diff/250001/chrome/app/chromeos_st...
chrome/app/chromeos_strings.grdp:85: <message
name="IDS_FILE_BROWSER_DRIVE_CONFIRM_MOVE_TO_TEAM_DRIVE_BODY" desc="Part of
message in the confirmation dialog box when moving or copying files into a Team
Drive.">
On 2017/06/12 10:41:59, fukino wrote:
> On 2017/06/12 10:35:23, yamaguchi wrote:
> > Should we also change these IDS_* message names mode describes the actual
> text,
> > like *_DRIVE_CONFIRM_GAIN_ACCESS ?
> 
> It's OK if the ID name describes the message content itself.

Done.