Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: ios/chrome/browser/translate/translate_ranker_metrics_provider.cc

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: rogerm's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/translate/translate_ranker_metrics_provider.cc
diff --git a/ios/chrome/browser/translate/translate_ranker_metrics_provider.cc b/ios/chrome/browser/translate/translate_ranker_metrics_provider.cc
index f8039ec6b73861f55188d4d258b7607d2a49e981..1cbf06168504c87ac1f75f5a531cb9467f6584b6 100644
--- a/ios/chrome/browser/translate/translate_ranker_metrics_provider.cc
+++ b/ios/chrome/browser/translate/translate_ranker_metrics_provider.cc
@@ -22,8 +22,7 @@ void TranslateRankerMetricsProvider::ProvideGeneralMetrics(
->GetChromeBrowserStateManager()
->GetLoadedBrowserStates();
for (auto* state : browser_states) {
- TranslateRanker* ranker =
- TranslateRankerFactory::GetInstance()->GetForBrowserState(state);
+ TranslateRanker* ranker = TranslateRankerFactory::GetForBrowserState(state);
DCHECK(ranker);
std::vector<metrics::TranslateEventProto> translate_events;
ranker->FlushTranslateEvents(&translate_events);
@@ -34,4 +33,24 @@ void TranslateRankerMetricsProvider::ProvideGeneralMetrics(
}
}
+void TranslateRankerMetricsProvider::SetLoggingState(bool logging_enabled) {
+ std::vector<ios::ChromeBrowserState*> browser_states =
+ GetApplicationContext()
+ ->GetChromeBrowserStateManager()
+ ->GetLoadedBrowserStates();
+ for (auto* state : browser_states) {
+ TranslateRanker* ranker = TranslateRankerFactory::GetForBrowserState(state);
+ DCHECK(ranker);
+ ranker->EnableLogging(logging_enabled);
+ }
+}
+
+void TranslateRankerMetricsProvider::OnRecordingEnabled() {
+ SetLoggingState(true);
+}
+
+void TranslateRankerMetricsProvider::OnRecordingDisabled() {
+ SetLoggingState(false);
+}
+
} // namespace translate

Powered by Google App Engine
This is Rietveld 408576698