Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: components/translate/core/browser/translate_ranker_impl_unittest.cc

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: rogerm's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ranker_impl_unittest.cc
diff --git a/components/translate/core/browser/translate_ranker_impl_unittest.cc b/components/translate/core/browser/translate_ranker_impl_unittest.cc
index b61b4b7bbfc5534808a8684d30668216657b0be9..bdc3306be474fc1cf7df751932eeab79e746b7c7 100644
--- a/components/translate/core/browser/translate_ranker_impl_unittest.cc
+++ b/components/translate/core/browser/translate_ranker_impl_unittest.cc
@@ -350,10 +350,11 @@ TEST_F(TranslateRankerImplTest, LoggingDisabledViaOverride) {
ranker->FlushTranslateEvents(&flushed_events);
EXPECT_EQ(3U, flushed_events.size());
- // Override the feature setting to disable logging.
+ ranker->RecordTranslateEvent(0, GURL(), &translate_event1_);
+ // Override the feature setting to disable logging. The event cache will be
+ // cleared.
ranker->EnableLogging(false);
groby-ooo-7-16 2017/06/07 16:27:22 I'd check for 0 flushed events here, too - otherwi
hamelphi 2017/06/08 20:27:58 Done. Added explicit tests for cache.
- ranker->RecordTranslateEvent(0, GURL(), &translate_event1_);
ranker->RecordTranslateEvent(1, GURL(), &translate_event2_);
ranker->RecordTranslateEvent(2, GURL(), &translate_event3_);

Powered by Google App Engine
This is Rietveld 408576698