Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1690)

Unified Diff: components/translate/core/browser/translate_ranker_impl.cc

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: rogerm's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ranker_impl.cc
diff --git a/components/translate/core/browser/translate_ranker_impl.cc b/components/translate/core/browser/translate_ranker_impl.cc
index d31d4718adabaa73fe5df4a2129f83f5a374f213..e8ad8825725d9829a48a76d8d72d32400f85cc2a 100644
--- a/components/translate/core/browser/translate_ranker_impl.cc
+++ b/components/translate/core/browser/translate_ranker_impl.cc
@@ -183,6 +183,8 @@ GURL TranslateRankerImpl::GetModelURL() {
void TranslateRankerImpl::EnableLogging(bool value) {
is_logging_enabled_ = value;
+ if (!is_logging_enabled_)
groby-ooo-7-16 2017/06/07 16:27:21 Don't you want to clear on every edge transition?
hamelphi 2017/06/08 20:27:58 Good point. Done.
+ event_cache_.clear();
}
uint32_t TranslateRankerImpl::GetModelVersion() const {

Powered by Google App Engine
This is Rietveld 408576698