Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: ios/chrome/browser/translate/translate_ranker_metrics_provider.h

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: Enable Logging in tests that use Flushing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/translate/translate_ranker_metrics_provider.h
diff --git a/ios/chrome/browser/translate/translate_ranker_metrics_provider.h b/ios/chrome/browser/translate/translate_ranker_metrics_provider.h
index 1933a4b3b6b64839b97b09b23f0b7a3e876ec45c..21c9d781a1680afbfc80cd5c0e742f2691076fda 100644
--- a/ios/chrome/browser/translate/translate_ranker_metrics_provider.h
+++ b/ios/chrome/browser/translate/translate_ranker_metrics_provider.h
@@ -12,13 +12,21 @@ namespace translate {
// Provides metrics related to the translate ranker.
class TranslateRankerMetricsProvider : public metrics::MetricsProvider {
public:
- TranslateRankerMetricsProvider() {}
+ TranslateRankerMetricsProvider() : logging_enabled_(false) {}
~TranslateRankerMetricsProvider() override {}
- private:
// From metrics::MetricsProvider...
void ProvideGeneralMetrics(
metrics::ChromeUserMetricsExtension* uma_proto) override;
+ void OnRecordingEnabled() override;
+ void OnRecordingDisabled() override;
+
+ private:
+ // Updates the logging state of all ranker instances.
+ void UpdateLoggingState();
+
+ // The current state of logging.
+ bool logging_enabled_;
DISALLOW_COPY_AND_ASSIGN(TranslateRankerMetricsProvider);
};

Powered by Google App Engine
This is Rietveld 408576698