Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: ios/chrome/browser/translate/translate_ranker_metrics_provider.cc

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: Enable Logging in tests that use Flushing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/translate/translate_ranker_metrics_provider.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/translate/translate_ranker_metrics_provider.cc
diff --git a/ios/chrome/browser/translate/translate_ranker_metrics_provider.cc b/ios/chrome/browser/translate/translate_ranker_metrics_provider.cc
index f8039ec6b73861f55188d4d258b7607d2a49e981..bbcab3b7177270405b01a8d4d6dff90e73da1990 100644
--- a/ios/chrome/browser/translate/translate_ranker_metrics_provider.cc
+++ b/ios/chrome/browser/translate/translate_ranker_metrics_provider.cc
@@ -22,9 +22,9 @@ void TranslateRankerMetricsProvider::ProvideGeneralMetrics(
->GetChromeBrowserStateManager()
->GetLoadedBrowserStates();
for (auto* state : browser_states) {
- TranslateRanker* ranker =
- TranslateRankerFactory::GetInstance()->GetForBrowserState(state);
+ TranslateRanker* ranker = TranslateRankerFactory::GetForBrowserState(state);
DCHECK(ranker);
+ UpdateLoggingState();
std::vector<metrics::TranslateEventProto> translate_events;
ranker->FlushTranslateEvents(&translate_events);
@@ -34,4 +34,26 @@ void TranslateRankerMetricsProvider::ProvideGeneralMetrics(
}
}
+void TranslateRankerMetricsProvider::UpdateLoggingState() {
+ std::vector<ios::ChromeBrowserState*> browser_states =
+ GetApplicationContext()
+ ->GetChromeBrowserStateManager()
+ ->GetLoadedBrowserStates();
+ for (auto* state : browser_states) {
+ TranslateRanker* ranker = TranslateRankerFactory::GetForBrowserState(state);
+ DCHECK(ranker);
+ ranker->EnableLogging(logging_enabled_);
+ }
+}
+
+void TranslateRankerMetricsProvider::OnRecordingEnabled() {
+ logging_enabled_ = true;
+ UpdateLoggingState();
+}
+
+void TranslateRankerMetricsProvider::OnRecordingDisabled() {
+ logging_enabled_ = false;
+ UpdateLoggingState();
+}
+
} // namespace translate
« no previous file with comments | « ios/chrome/browser/translate/translate_ranker_metrics_provider.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698