Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2877)

Unified Diff: chrome/browser/translate/translate_ranker_metrics_provider.h

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: Enable Logging in tests that use Flushing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/translate/translate_ranker_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_ranker_metrics_provider.h
diff --git a/chrome/browser/translate/translate_ranker_metrics_provider.h b/chrome/browser/translate/translate_ranker_metrics_provider.h
index 7490cab99dcf4c6d12f4b88e6c82580aaceead3a..65af105aad4b0870887b317643b92cbd8c69a965 100644
--- a/chrome/browser/translate/translate_ranker_metrics_provider.h
+++ b/chrome/browser/translate/translate_ranker_metrics_provider.h
@@ -12,13 +12,22 @@ namespace translate {
// Provides metrics related to the translate ranker.
class TranslateRankerMetricsProvider : public metrics::MetricsProvider {
public:
- TranslateRankerMetricsProvider() {}
+ TranslateRankerMetricsProvider() : logging_enabled_(false) {}
+
~TranslateRankerMetricsProvider() override {}
- private:
// From metrics::MetricsProvider...
void ProvideGeneralMetrics(
metrics::ChromeUserMetricsExtension* uma_proto) override;
+ void OnRecordingEnabled() override;
+ void OnRecordingDisabled() override;
+
+ private:
+ // Updates the logging state of all ranker instances.
+ void UpdateLoggingState();
+
+ // The current state of logging.
+ bool logging_enabled_;
DISALLOW_COPY_AND_ASSIGN(TranslateRankerMetricsProvider);
};
« no previous file with comments | « no previous file | chrome/browser/translate/translate_ranker_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698