Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: chrome/browser/translate/translate_ranker_metrics_provider.cc

Issue 2930433004: Send UMA recording state to TranslateRanker. (Closed)
Patch Set: Enable Logging in tests that use Flushing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_ranker_metrics_provider.cc
diff --git a/chrome/browser/translate/translate_ranker_metrics_provider.cc b/chrome/browser/translate/translate_ranker_metrics_provider.cc
index ba98a639a5fa96c621120d1812414fecc52f5f08..cefb656814b1e61150e531919afdf32ad03e5d7d 100644
--- a/chrome/browser/translate/translate_ranker_metrics_provider.cc
+++ b/chrome/browser/translate/translate_ranker_metrics_provider.cc
@@ -21,8 +21,9 @@ void TranslateRankerMetricsProvider::ProvideGeneralMetrics(
TranslateRanker* ranker =
TranslateRankerFactory::GetForBrowserContext(profile);
if (!ranker)
- return;
+ continue;
+ UpdateLoggingState();
std::vector<metrics::TranslateEventProto> translate_events;
ranker->FlushTranslateEvents(&translate_events);
@@ -32,4 +33,25 @@ void TranslateRankerMetricsProvider::ProvideGeneralMetrics(
}
}
+void TranslateRankerMetricsProvider::UpdateLoggingState() {
+ std::vector<Profile*> loaded_profiles =
+ g_browser_process->profile_manager()->GetLoadedProfiles();
+ for (Profile* profile : loaded_profiles) {
+ TranslateRanker* ranker =
+ TranslateRankerFactory::GetForBrowserContext(profile);
+ if (ranker)
+ ranker->EnableLogging(logging_enabled_);
+ }
+}
+
+void TranslateRankerMetricsProvider::OnRecordingEnabled() {
+ logging_enabled_ = true;
+ UpdateLoggingState();
+}
+
+void TranslateRankerMetricsProvider::OnRecordingDisabled() {
+ logging_enabled_ = false;
+ UpdateLoggingState();
+}
+
} // namespace translate

Powered by Google App Engine
This is Rietveld 408576698