Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2930433003: [turbofan] Try to update deprecated maps first. (Closed)

Created:
3 years, 6 months ago by Benedikt Meurer
Modified:
3 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Try to update deprecated maps first. When optimizing stores to data properties in literals, we need to first migrate deprecated maps before we lookup the property access infos for those. BUG=chromium:724608 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2930433003 Cr-Commit-Position: refs/heads/master@{#45727} Committed: https://chromium.googlesource.com/v8/v8/+/468446d5fc24148086097aac0ed166c02da56416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-724608.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 6 months ago (2017-06-06 11:15:47 UTC) #1
Jarin
lgtm
3 years, 6 months ago (2017-06-06 12:09:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930433003/1
3 years, 6 months ago (2017-06-06 12:09:18 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 12:10:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/468446d5fc24148086097aac0ed166c02da...

Powered by Google App Engine
This is Rietveld 408576698