Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 293043003: <webview>: Move PreHandleGestureEvent in chrome (Closed)

Created:
6 years, 7 months ago by Fady Samuel
Modified:
6 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

<webview>: Move PreHandleGestureEvent in chrome BUG=364141, 330264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272344

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed nit #

Patch Set 3 : Merge with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M chrome/browser/guest_view/guest_view_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Fady Samuel
6 years, 7 months ago (2014-05-20 20:40:56 UTC) #1
jam
lgtm https://codereview.chromium.org/293043003/diff/1/content/public/browser/browser_plugin_guest_delegate.h File content/public/browser/browser_plugin_guest_delegate.h (right): https://codereview.chromium.org/293043003/diff/1/content/public/browser/browser_plugin_guest_delegate.h#newcode213 content/public/browser/browser_plugin_guest_delegate.h:213: virtual bool PreHandleGestureEvent(content::WebContents* source, no content::
6 years, 7 months ago (2014-05-21 16:44:38 UTC) #2
Fady Samuel
Addressed nit. CQ'ing after the name attribute change is committed. https://codereview.chromium.org/293043003/diff/1/content/public/browser/browser_plugin_guest_delegate.h File content/public/browser/browser_plugin_guest_delegate.h (right): https://codereview.chromium.org/293043003/diff/1/content/public/browser/browser_plugin_guest_delegate.h#newcode213 ...
6 years, 7 months ago (2014-05-22 13:37:49 UTC) #3
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-22 18:36:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/293043003/40001
6 years, 7 months ago (2014-05-22 18:40:27 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 22:18:51 UTC) #6
Message was sent while issue was closed. 
Change committed as 272344

Powered by Google App Engine
This is Rietveld 408576698