content/browser/browser_plugin/browser_plugin_guest.cc - Issue 293043003: <webview>: Move PreHandleGestureEvent in chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 293043003: <webview>: Move PreHandleGestureEvent in chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with ToT Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index 15ec3ba824da61e29a9136f59c96fc1ff5b6d6e6..0eebca783f0dc31122a20ac916e1fd3de55979fa 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -1097,9 +1097,10 @@ void BrowserPluginGuest::RequestMediaAccessPermission(

bool BrowserPluginGuest::PreHandleGestureEvent(

WebContents* source, const blink::WebGestureEvent& event) {

- return event.type == blink::WebGestureEvent::GesturePinchBegin ||

- event.type == blink::WebGestureEvent::GesturePinchUpdate ||

- event.type == blink::WebGestureEvent::GesturePinchEnd;

+ if (!delegate_)

+ return false;

+ return delegate_->PreHandleGestureEvent(source, event);

}

void BrowserPluginGuest::OnUpdateRect(