Revert "[ios] Ensure proper shutdown of Chrome on iOS."

Revert "[ios] Ensure proper shutdown of Chrome on iOS."

This reverts commit 1c7e3e09531837467cb3f412a72e373853e575aa.

Breaks PhoneSimulator and TabletSimulator bots:

Failed steps failed ios_chrome_integration_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_settings_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_ui_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed ios_internal_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed failure reason

[0612/124347.435892:FATAL:browser_view_controller.mm(995)] Check failed: _isShutdown. -shutdown must be called before dealloc.

TBR=sdefresne@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2930363003
Cr-Commit-Position: refs/heads/master@{#478783}
Committed: https://chromium.googlesource.com/chromium/src/+/7978ea6ffb6953be4dee38cc07f393b0c772497d

[justincohen, 2017-06-12 21:24:11]

Description was changed from

==========
Revert "[ios] Ensure proper shutdown of Chrome on iOS."

This reverts commit 1c7e3e09531837467cb3f412a72e373853e575aa.

BUG=
==========

to

==========
Revert "[ios] Ensure proper shutdown of Chrome on iOS."

This reverts commit 1c7e3e09531837467cb3f412a72e373853e575aa.

Breaks PhoneSimulator and TabletSimulator bots:

Failed steps failed ios_chrome_integration_egtests (iphone 5 ios 10.0) on mac
failed ios_chrome_settings_egtests (iphone 5 ios 10.0) on mac failed
ios_chrome_ui_egtests (iphone 5 ios 10.0) on mac failed
ios_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed
ios_internal_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed
failure reason

[0612/124347.435892:FATAL:browser_view_controller.mm(995)] Check failed:
_isShutdown. -shutdown must be called before dealloc.

TBR=sdefresne@chromium.org
BUG=
==========

[justincohen, 2017-06-12 21:24:11]

justincohen@chromium.org changed reviewers:
+ edchin@chromium.org, sdefresne@chromium.org

[edchin, 2017-06-12 21:25:41]

The CQ bit was checked by edchin@chromium.org

[commit-bot: I haz the power, 2017-06-12 21:26:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 22:04:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497302741327970, "parent_rev":
"4396b7a7ed40e6260568f14f52649d998a121b8d", "commit_rev":
"7978ea6ffb6953be4dee38cc07f393b0c772497d"}

[commit-bot: I haz the power, 2017-06-12 22:05:07]

Description was changed from

==========
Revert "[ios] Ensure proper shutdown of Chrome on iOS."

This reverts commit 1c7e3e09531837467cb3f412a72e373853e575aa.

Breaks PhoneSimulator and TabletSimulator bots:

Failed steps failed ios_chrome_integration_egtests (iphone 5 ios 10.0) on mac
failed ios_chrome_settings_egtests (iphone 5 ios 10.0) on mac failed
ios_chrome_ui_egtests (iphone 5 ios 10.0) on mac failed
ios_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed
ios_internal_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed
failure reason

[0612/124347.435892:FATAL:browser_view_controller.mm(995)] Check failed:
_isShutdown. -shutdown must be called before dealloc.

TBR=sdefresne@chromium.org
BUG=
==========

to

==========
Revert "[ios] Ensure proper shutdown of Chrome on iOS."

This reverts commit 1c7e3e09531837467cb3f412a72e373853e575aa.

Breaks PhoneSimulator and TabletSimulator bots:

Failed steps failed ios_chrome_integration_egtests (iphone 5 ios 10.0) on mac
failed ios_chrome_settings_egtests (iphone 5 ios 10.0) on mac failed
ios_chrome_ui_egtests (iphone 5 ios 10.0) on mac failed
ios_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed
ios_internal_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed
failure reason

[0612/124347.435892:FATAL:browser_view_controller.mm(995)] Check failed:
_isShutdown. -shutdown must be called before dealloc.

TBR=sdefresne@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2930363003
Cr-Commit-Position: refs/heads/master@{#478783}
Committed:
https://chromium.googlesource.com/chromium/src/+/7978ea6ffb6953be4dee38cc07f3...
==========

[commit-bot: I haz the power, 2017-06-12 22:05:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7978ea6ffb6953be4dee38cc07f3...

[sdefresne, 2017-06-13 08:11:43]

On 2017/06/12 22:05:07, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/7978ea6ffb6953be4dee38cc07f3...

lgtm but why didn't you use the "Revert" button in the gerrit UI?

[sdefresne, 2017-06-13 08:38:10]

On 2017/06/13 08:11:43, sdefresne wrote:
> On 2017/06/12 22:05:07, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/7978ea6ffb6953be4dee38cc07f3...
> 
> lgtm but why didn't you use the "Revert" button in the gerrit UI?

Ah, this is because it conflicted with the conversion of main_controller.mm to
ARC.