Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2930343002: Fuchsia: implement OS::Allocate (Closed)

Created:
3 years, 6 months ago by scottmg
Modified:
3 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Fuchsia: implement OS::Allocate Fix v8 link errors (in component_build=true) https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20(dbg) BUG=chromium:731217 Review-Url: https://codereview.chromium.org/2930343002 Cr-Commit-Position: refs/heads/master@{#45878} Committed: https://chromium.googlesource.com/v8/v8/+/2094202be215a07f3fab6a3a24fda644fe6ab048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/base/platform/platform-fuchsia.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
scottmg
3 years, 6 months ago (2017-06-12 17:13:36 UTC) #5
Benedikt Meurer
lgtm
3 years, 6 months ago (2017-06-12 17:48:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930343002/1
3 years, 6 months ago (2017-06-12 17:48:43 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 17:50:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2094202be215a07f3fab6a3a24fda644fe6...

Powered by Google App Engine
This is Rietveld 408576698