Show client placeholders for Server LoFi images.

chrome/browser/about_flags.cc

Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 9ec24e7299ca4603becfbac15b1d2c5880967d21..3b4a97c5e4197ca5cd9d98cfbe0b0bf59d6e23fd 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1899,6 +1899,13 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kEnableDataReductionProxyServerExperimentName,
      flag_descriptions::kEnableDataReductionProxyServerExperimentDescription,
      kOsAll, MULTI_VALUE_TYPE(kDataReductionProxyServerExperiment)},
+    {"enable-show-client-placeholders-for-server-lo-fi",

[megjablon, 2017/06/29 17:35:48]

You could probably shorten this everywhere by removing "show". I think that
reads better too "enable-client-placeholders-for-server-lo-fi"

[sclittle, 2017/06/29 21:27:58]

Done.

+     flag_descriptions::kEnableShowClientPlaceholdersForServerLoFiName,
+     flag_descriptions::kEnableShowClientPlaceholdersForServerLoFiDescription,
+     kOsAll,
+     ENABLE_DISABLE_VALUE_TYPE(
+         switches::kEnableShowClientPlaceholdersForServerLoFi,
+         switches::kDisableShowClientPlaceholdersForServerLoFi)},

[megjablon, 2017/06/29 17:35:48]

We should probably be using a feature instead of a field trial for client lo-fi.
Is there a particular reason we aren't? Instead of using command line switches
and a separate about flag for the param, I would use
FEATURE_WITH_PARAMS_VALUE_TYPE. See kDataReductionMainMenuFeatureVariations.

[sclittle, 2017/06/29 21:27:58]

Great idea, thanks! Done.

[megjablon, 2017/06/30 18:19:21]

Woot! This looks a lot cleaner!

 #if defined(OS_ANDROID)
     {"enable-data-reduction-proxy-savings-promo",
      flag_descriptions::kEnableDataReductionProxySavingsPromoName,