Show client placeholders for Server LoFi images.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 1881 matching lines @@
      MULTI_VALUE_TYPE(kDataReductionProxyLoFiChoices)},
     {"enable-data-reduction-proxy-lite-page",
      flag_descriptions::kEnableDataReductionProxyLitePageName,
      flag_descriptions::kEnableDataReductionProxyLitePageDescription, kOsAll,
      SINGLE_VALUE_TYPE(
          data_reduction_proxy::switches::kEnableDataReductionProxyLitePage)},
     {"enable-data-reduction-proxy-server-experiment",
      flag_descriptions::kEnableDataReductionProxyServerExperimentName,
      flag_descriptions::kEnableDataReductionProxyServerExperimentDescription,
      kOsAll, MULTI_VALUE_TYPE(kDataReductionProxyServerExperiment)},
+    {"enable-show-client-placeholders-for-server-lo-fi",

[megjablon, 2017/06/29 17:35:48]

You could probably shorten this everywhere by removing "show". I think that
reads better too "enable-client-placeholders-for-server-lo-fi"

[sclittle, 2017/06/29 21:27:58]

Done.

+     flag_descriptions::kEnableShowClientPlaceholdersForServerLoFiName,
+     flag_descriptions::kEnableShowClientPlaceholdersForServerLoFiDescription,
+     kOsAll,
+     ENABLE_DISABLE_VALUE_TYPE(
+         switches::kEnableShowClientPlaceholdersForServerLoFi,
+         switches::kDisableShowClientPlaceholdersForServerLoFi)},

[megjablon, 2017/06/29 17:35:48]

We should probably be using a feature instead of a field trial for client lo-fi.
Is there a particular reason we aren't? Instead of using command line switches
and a separate about flag for the param, I would use
FEATURE_WITH_PARAMS_VALUE_TYPE. See kDataReductionMainMenuFeatureVariations.

[sclittle, 2017/06/29 21:27:58]

Great idea, thanks! Done.

[megjablon, 2017/06/30 18:19:21]

Woot! This looks a lot cleaner!

 #if defined(OS_ANDROID)
     {"enable-data-reduction-proxy-savings-promo",
      flag_descriptions::kEnableDataReductionProxySavingsPromoName,
      flag_descriptions::kEnableDataReductionProxySavingsPromoDescription,
      kOsAndroid,
      SINGLE_VALUE_TYPE(data_reduction_proxy::switches::
                            kEnableDataReductionProxySavingsPromo)},
     {"enable-data-reduction-proxy-main-menu",
      flag_descriptions::kEnableDataReductionProxyMainMenuName,
      flag_descriptions::kEnableDataReductionProxyMainMenuDescription,
@@ skipping 1350 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags