Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1794)

Unified Diff: chrome/browser/about_flags.cc

Issue 2930323003: Show client placeholders for Server LoFi images. (Closed)
Patch Set: rebase flag_descriptions.cc Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 0e45042dbf10f0740ea69d88cc8d7960c11b81c4..ca51038e3a73beb43c1597799d8d97c4d69edfef 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1081,6 +1081,15 @@ const FeatureEntry::FeatureVariation kOmniboxUIVerticalMarginVariations[] = {
{"14px vertical margin", kOmniboxUIVerticalMargin14px,
arraysize(kOmniboxUIVerticalMargin14px), nullptr}};
+const FeatureEntry::FeatureParam kClientPlaceholdersForServerLoFiEnabled[] = {
+ {"replace_server_placeholders", "true"}};
+
+const FeatureEntry::FeatureVariation
+ kClientPlaceholdersForServerLoFiFeatureVariations[] = {
+ {"(replace Server Lo-Fi placeholders)",
+ kClientPlaceholdersForServerLoFiEnabled,
+ arraysize(kClientPlaceholdersForServerLoFiEnabled), nullptr}};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the entry is the internal name.
@@ -1994,10 +2003,13 @@ const FeatureEntry kFeatureEntries[] = {
{"enable-offline-previews", flag_descriptions::kEnableOfflinePreviewsName,
flag_descriptions::kEnableOfflinePreviewsDescription, kOsAndroid,
FEATURE_VALUE_TYPE(previews::features::kOfflinePreviews)},
- {"enable-client-lo-fi", flag_descriptions::kEnableClientLoFiName,
- flag_descriptions::kEnableClientLoFiDescription, kOsAndroid,
- FEATURE_VALUE_TYPE(previews::features::kClientLoFi)},
#endif // OS_ANDROID
+ {"enable-client-lo-fi", flag_descriptions::kEnableClientLoFiName,
+ flag_descriptions::kEnableClientLoFiDescription, kOsAll,
+ FEATURE_WITH_PARAMS_VALUE_TYPE(
+ previews::features::kClientLoFi,
+ kClientPlaceholdersForServerLoFiFeatureVariations,
+ "PreviewsClientLoFi")},
{"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhostName,
flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll,
SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)},
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698