Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2930323003: Show client placeholders for Server LoFi images. (Closed)
Patch Set: rebase flag_descriptions.cc Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1063 matching lines...) Expand 10 before | Expand all | Expand 10 after
1074 arraysize(kOmniboxUIVerticalMargin6px), nullptr}, 1074 arraysize(kOmniboxUIVerticalMargin6px), nullptr},
1075 {"8px vertical margin", kOmniboxUIVerticalMargin8px, 1075 {"8px vertical margin", kOmniboxUIVerticalMargin8px,
1076 arraysize(kOmniboxUIVerticalMargin8px), nullptr}, 1076 arraysize(kOmniboxUIVerticalMargin8px), nullptr},
1077 {"10px vertical margin", kOmniboxUIVerticalMargin10px, 1077 {"10px vertical margin", kOmniboxUIVerticalMargin10px,
1078 arraysize(kOmniboxUIVerticalMargin10px), nullptr}, 1078 arraysize(kOmniboxUIVerticalMargin10px), nullptr},
1079 {"12px vertical margin", kOmniboxUIVerticalMargin12px, 1079 {"12px vertical margin", kOmniboxUIVerticalMargin12px,
1080 arraysize(kOmniboxUIVerticalMargin12px), nullptr}, 1080 arraysize(kOmniboxUIVerticalMargin12px), nullptr},
1081 {"14px vertical margin", kOmniboxUIVerticalMargin14px, 1081 {"14px vertical margin", kOmniboxUIVerticalMargin14px,
1082 arraysize(kOmniboxUIVerticalMargin14px), nullptr}}; 1082 arraysize(kOmniboxUIVerticalMargin14px), nullptr}};
1083 1083
1084 const FeatureEntry::FeatureParam kClientPlaceholdersForServerLoFiEnabled[] = {
1085 {"replace_server_placeholders", "true"}};
1086
1087 const FeatureEntry::FeatureVariation
1088 kClientPlaceholdersForServerLoFiFeatureVariations[] = {
1089 {"(replace Server Lo-Fi placeholders)",
1090 kClientPlaceholdersForServerLoFiEnabled,
1091 arraysize(kClientPlaceholdersForServerLoFiEnabled), nullptr}};
1092
1084 // RECORDING USER METRICS FOR FLAGS: 1093 // RECORDING USER METRICS FOR FLAGS:
1085 // ----------------------------------------------------------------------------- 1094 // -----------------------------------------------------------------------------
1086 // The first line of the entry is the internal name. 1095 // The first line of the entry is the internal name.
1087 // 1096 //
1088 // To add a new entry, add to the end of kFeatureEntries. There are two 1097 // To add a new entry, add to the end of kFeatureEntries. There are two
1089 // distinct types of entries: 1098 // distinct types of entries:
1090 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE 1099 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE
1091 // macro for this type supplying the command line to the macro. 1100 // macro for this type supplying the command line to the macro.
1092 // . MULTI_VALUE: a list of choices, the first of which should correspond to a 1101 // . MULTI_VALUE: a list of choices, the first of which should correspond to a
1093 // deactivated state for this lab (i.e. no command line option). To specify 1102 // deactivated state for this lab (i.e. no command line option). To specify
(...skipping 893 matching lines...) Expand 10 before | Expand all | Expand 10 after
1987 "DataReductionProxyMainMenu")}, 1996 "DataReductionProxyMainMenu")},
1988 {"enable-data-reduction-proxy-site-breakdown", 1997 {"enable-data-reduction-proxy-site-breakdown",
1989 flag_descriptions::kEnableDataReductionProxySiteBreakdownName, 1998 flag_descriptions::kEnableDataReductionProxySiteBreakdownName,
1990 flag_descriptions::kEnableDataReductionProxySiteBreakdownDescription, 1999 flag_descriptions::kEnableDataReductionProxySiteBreakdownDescription,
1991 kOsAndroid, 2000 kOsAndroid,
1992 FEATURE_VALUE_TYPE( 2001 FEATURE_VALUE_TYPE(
1993 data_reduction_proxy::features::kDataReductionSiteBreakdown)}, 2002 data_reduction_proxy::features::kDataReductionSiteBreakdown)},
1994 {"enable-offline-previews", flag_descriptions::kEnableOfflinePreviewsName, 2003 {"enable-offline-previews", flag_descriptions::kEnableOfflinePreviewsName,
1995 flag_descriptions::kEnableOfflinePreviewsDescription, kOsAndroid, 2004 flag_descriptions::kEnableOfflinePreviewsDescription, kOsAndroid,
1996 FEATURE_VALUE_TYPE(previews::features::kOfflinePreviews)}, 2005 FEATURE_VALUE_TYPE(previews::features::kOfflinePreviews)},
2006 #endif // OS_ANDROID
1997 {"enable-client-lo-fi", flag_descriptions::kEnableClientLoFiName, 2007 {"enable-client-lo-fi", flag_descriptions::kEnableClientLoFiName,
1998 flag_descriptions::kEnableClientLoFiDescription, kOsAndroid, 2008 flag_descriptions::kEnableClientLoFiDescription, kOsAll,
1999 FEATURE_VALUE_TYPE(previews::features::kClientLoFi)}, 2009 FEATURE_WITH_PARAMS_VALUE_TYPE(
2000 #endif // OS_ANDROID 2010 previews::features::kClientLoFi,
2011 kClientPlaceholdersForServerLoFiFeatureVariations,
2012 "PreviewsClientLoFi")},
2001 {"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhostName, 2013 {"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhostName,
2002 flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll, 2014 flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll,
2003 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)}, 2015 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)},
2004 #if !defined(OS_ANDROID) 2016 #if !defined(OS_ANDROID)
2005 {"enable-app-banners", flag_descriptions::kAppBannersName, 2017 {"enable-app-banners", flag_descriptions::kAppBannersName,
2006 flag_descriptions::kAppBannersDescription, kOsDesktop, 2018 flag_descriptions::kAppBannersDescription, kOsDesktop,
2007 FEATURE_VALUE_TYPE(features::kAppBanners)}, 2019 FEATURE_VALUE_TYPE(features::kAppBanners)},
2008 #endif // !OS_ANDROID 2020 #endif // !OS_ANDROID
2009 {"enable-experimental-app-banners", 2021 {"enable-experimental-app-banners",
2010 flag_descriptions::kExperimentalAppBannersName, 2022 flag_descriptions::kExperimentalAppBannersName,
(...skipping 1342 matching lines...) Expand 10 before | Expand all | Expand 10 after
3353 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3365 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3354 3366
3355 const FeatureEntry* GetFeatureEntries(size_t* count) { 3367 const FeatureEntry* GetFeatureEntries(size_t* count) {
3356 *count = arraysize(kFeatureEntries); 3368 *count = arraysize(kFeatureEntries);
3357 return kFeatureEntries; 3369 return kFeatureEntries;
3358 } 3370 }
3359 3371
3360 } // namespace testing 3372 } // namespace testing
3361 3373
3362 } // namespace about_flags 3374 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698