Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2930303002: [ObjC ARC] Converts ios/chrome/browser/signin:test_support to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/signin:test_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2930303002 Cr-Commit-Position: refs/heads/master@{#478995} Committed: https://chromium.googlesource.com/chromium/src/+/4f7c2dc19663809614de436582a442520a6be0c6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added explicit annotation. #

Patch Set 3 : [ObjC ARC] Converts ios/public/provider/chrome/browser/signin:test_support to ARC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -33 lines) Patch
M ios/public/provider/chrome/browser/signin/fake_chrome_identity.mm View 1 2 2 chunks +8 lines, -10 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/fake_chrome_identity_interaction_manager.mm View 1 2 4 chunks +16 lines, -15 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm View 1 2 5 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 11:08:28 UTC) #4
stkhapugin
lgtm https://codereview.chromium.org/2930303002/diff/1/ios/chrome/browser/signin/authentication_service_fake.h File ios/chrome/browser/signin/authentication_service_fake.h (right): https://codereview.chromium.org/2930303002/diff/1/ios/chrome/browser/signin/authentication_service_fake.h#newcode44 ios/chrome/browser/signin/authentication_service_fake.h:44: ChromeIdentity* authenticated_identity_; Please annotate with explicit __strong
3 years, 6 months ago (2017-06-13 11:45:39 UTC) #7
marq (ping after 24h)
Added explicit annotation.
3 years, 6 months ago (2017-06-13 11:58:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930303002/20001
3 years, 6 months ago (2017-06-13 11:59:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4f7c2dc19663809614de436582a442520a6be0c6
3 years, 6 months ago (2017-06-13 13:24:41 UTC) #14
marq (ping after 24h)
3 years, 6 months ago (2017-06-15 09:54:18 UTC) #15
Message was sent while issue was closed.
[ObjC ARC] Converts ios/public/provider/chrome/browser/signin:test_support to
ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Powered by Google App Engine
This is Rietveld 408576698