Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2827)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java

Issue 29303004: Make WindowAndroid constructor takes context as param. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java
index fc8f4edd98adb5d2831b3d3bb9fb66ad893e93c1..6e9e3443abfcefa5abdffb9a70acb1a10b1baacf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.browser.autofill;
+import android.content.Context;
+
import org.chromium.base.CalledByNative;
import org.chromium.base.JNINamespace;
import org.chromium.ui.ViewAndroid;
@@ -24,7 +26,9 @@ public class AutofillPopupGlue implements AutofillPopupDelegate{
public AutofillPopupGlue(int nativeAutofillPopupViewAndroid, WindowAndroid windowAndroid,
ViewAndroidDelegate containerViewDelegate) {
mNativeAutofillPopup = nativeAutofillPopupViewAndroid;
- mAutofillPopup = new AutofillPopup(windowAndroid.getContext(), containerViewDelegate, this);
+ Context context = windowAndroid.getContext();
+ assert context != null;
+ mAutofillPopup = new AutofillPopup(context, containerViewDelegate, this);
joth 2013/11/01 18:45:01 Is the edit in this file really needed? You're goi
michaelbai 2013/11/01 21:27:05 I am planing to remove this deprecated method comp
}
@CalledByNative

Powered by Google App Engine
This is Rietveld 408576698