Make WindowAndroid constructor takes context as param.

chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.autofill;
 
+import android.content.Context;
+
 import org.chromium.base.CalledByNative;
 import org.chromium.base.JNINamespace;
 import org.chromium.ui.ViewAndroid;
 import org.chromium.ui.ViewAndroidDelegate;
 import org.chromium.ui.WindowAndroid;
 import org.chromium.ui.autofill.AutofillPopup;
 import org.chromium.ui.autofill.AutofillPopup.AutofillPopupDelegate;
 import org.chromium.ui.autofill.AutofillSuggestion;
 
 /**
 * JNI call glue for AutofillExternalDelagate C++ and Java objects.
 */
 @JNINamespace("autofill")
 public class AutofillPopupGlue implements AutofillPopupDelegate{
     private final int mNativeAutofillPopup;
     private final AutofillPopup mAutofillPopup;
 
     public AutofillPopupGlue(int nativeAutofillPopupViewAndroid, WindowAndroid windowAndroid,
             ViewAndroidDelegate containerViewDelegate) {
         mNativeAutofillPopup = nativeAutofillPopupViewAndroid;
-        mAutofillPopup = new AutofillPopup(windowAndroid.getContext(), containerViewDelegate, this);
+        Context context = windowAndroid.getContext();
+        assert context != null;
+        mAutofillPopup = new AutofillPopup(context, containerViewDelegate, this);

[joth, 2013/11/01 18:45:01]

Is the edit in this file really needed? You're going to get a NPE inside
AutofillPopup c'tor anyway, which will be just as obvious what went wrong

Although technically I think the correct thing is to return null from create()
and wind that all the way back so AutofillPopupView::Create() returns NULL on
the native side (which it's allowed to, and is handled already).
This will handle the case of an offscreen webview having key-events
programmatically injected and causing us to hit this autofill path.

[michaelbai, 2013/11/01 21:27:05]

I am planing to remove this deprecated method completely.  I reset all the
change and recorded you comments at  http://crbug.com/233440

On 2013/11/01 18:45:01, joth wrote:

     }
 
     @CalledByNative
     private static AutofillPopupGlue create(int nativeAutofillPopupViewAndroid,
             WindowAndroid windowAndroid, ViewAndroid viewAndroid) {
         return new AutofillPopupGlue(nativeAutofillPopupViewAndroid, windowAndroid,
                 viewAndroid.getViewAndroidDelegate());
     }
 
     @Override
@@ skipping 52 matching lines @@
     @CalledByNative
     private static void addToAutofillSuggestionArray(AutofillSuggestion[] array, int index,
             String label, String sublabel, int uniqueId) {
         array[index] = new AutofillSuggestion(label, sublabel, uniqueId);
     }
 
     private native void nativeRequestHide(int nativeAutofillPopupViewAndroid);
     private native void nativeSuggestionSelected(int nativeAutofillPopupViewAndroid,
             int listIndex);
 }