Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and ui/ozone

Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and ui/ozone

BUG=561800
Review-Url: https://codereview.chromium.org/2930273002
Cr-Commit-Position: refs/heads/master@{#479307}
Committed: https://chromium.googlesource.com/chromium/src/+/3f97e999cf8835100a368e51b754d40e6863d497

[Tripta, 2017-06-12 07:01:23]

Description was changed from

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Tripta, 2017-06-12 07:05:29]

Description was changed from

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
==========

[Tripta, 2017-06-12 07:09:12]

tripta.g@samsung.com changed reviewers:
+ sadrul@chromium.org, sadrul@google.com

[Tripta, 2017-06-12 07:11:00]

Hi Sadrul,

Please review following files:
  ui/accessibility/ax_position.h
  ui/accessibility/ax_tree_unittest.cc
  ui/gl/gl_implementation.cc
  ui/gl/test/egl_initialization_displays_unittest.cc
  ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc

Regards
Tripta

[Tripta, 2017-06-12 07:13:08]

tripta.g@samsung.com changed reviewers:
+ a.suchit@samsung.com

[sadrul, 2017-06-14 02:43:01]

Some nits. lgtm with those addressed.

https://codereview.chromium.org/2930273002/diff/1/ui/accessibility/ax_tree_un...
File ui/accessibility/ax_tree_unittest.cc (right):

https://codereview.chromium.org/2930273002/diff/1/ui/accessibility/ax_tree_un...
ui/accessibility/ax_tree_unittest.cc:520:
ASSERT(!base::ContainsValue(node_reparented, 3));
Use ASSERT_FALSE/ASSERT_TRUE in the above.

https://codereview.chromium.org/2930273002/diff/1/ui/ozone/platform/drm/gpu/h...
File ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc (right):

https://codereview.chromium.org/2930273002/diff/1/ui/ozone/platform/drm/gpu/h...
ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc:42: if
(!found) {
Don't need |found|. Just check if (base::ContainsValue(...))?

[Tripta, 2017-06-14 03:45:34]

Description was changed from

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Tripta, 2017-06-14 03:46:03]

Description was changed from

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
==========

[Tripta, 2017-06-14 03:48:47]

The CQ bit was checked by tripta.g@samsung.com

[Tripta, 2017-06-14 03:48:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2930273002/#ps20001
(title: "Used ASSERT_FALSE and ASSERT_TRUE.")

[commit-bot: I haz the power, 2017-06-14 03:48:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 03:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 03:51:10]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[a.suchit2, 2017-06-14 04:42:24]

a.suchit@chromium.org changed reviewers:
+ a.suchit@chromium.org

[a.suchit2, 2017-06-14 04:42:25]

Please rebase the patch.

[Tripta, 2017-06-14 05:36:13]

Description was changed from

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Tripta, 2017-06-14 05:38:03]

Description was changed from

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
==========

[Tripta, 2017-06-14 05:39:41]

The CQ bit was checked by tripta.g@samsung.com

[Tripta, 2017-06-14 05:39:42]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2930273002/#ps40001
(title: "Rebase patch")

[commit-bot: I haz the power, 2017-06-14 05:39:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tripta, 2017-06-14 05:46:17]

Have made the changes. Please check.

Regards
Tripta

https://codereview.chromium.org/2930273002/diff/1/ui/accessibility/ax_tree_un...
File ui/accessibility/ax_tree_unittest.cc (right):

https://codereview.chromium.org/2930273002/diff/1/ui/accessibility/ax_tree_un...
ui/accessibility/ax_tree_unittest.cc:520:
ASSERT(!base::ContainsValue(node_reparented, 3));
On 2017/06/14 02:43:01, sadrul wrote:
> Use ASSERT_FALSE/ASSERT_TRUE in the above.

Done.

https://codereview.chromium.org/2930273002/diff/1/ui/ozone/platform/drm/gpu/h...
File ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc (right):

https://codereview.chromium.org/2930273002/diff/1/ui/ozone/platform/drm/gpu/h...
ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc:42: if
(!found) {
On 2017/06/14 02:43:01, sadrul wrote:
> Don't need |found|. Just check if (base::ContainsValue(...))?

Done.

[commit-bot: I haz the power, 2017-06-14 06:51:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497418781936650,
"parent_rev": "73c615314462fcb1eb0774d9be2cbccfb5c38414", "commit_rev":
"3f97e999cf8835100a368e51b754d40e6863d497"}

[commit-bot: I haz the power, 2017-06-14 06:51:29]

Description was changed from

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and
ui/ozone

BUG=561800

Review-Url: https://codereview.chromium.org/2930273002
Cr-Commit-Position: refs/heads/master@{#479307}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f97e999cf8835100a368e51b754...
==========

[commit-bot: I haz the power, 2017-06-14 06:51:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3f97e999cf8835100a368e51b754...