Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2930203002: fix test runner to understand mutlitests that expect an error (Closed)

Created:
3 years, 6 months ago by Jennifer Messerly
Modified:
3 years, 6 months ago
Reviewers:
vsm, Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix test runner to understand mutlitests that expect an error R=rnystrom@google.com, vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/cb038cda2f031e8ad11840a4a5eee00ed9d368c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -32 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 12 chunks +13 lines, -31 lines 0 comments Download
M pkg/dev_compiler/test/multitest.dart View 2 chunks +11 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/run.js View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
I hit this unexpectedly when I fixed DDC to correctly throw an error (in another ...
3 years, 6 months ago (2017-06-10 03:49:34 UTC) #2
vsm
oh wow - lgtm!
3 years, 6 months ago (2017-06-12 22:51:19 UTC) #3
Bob Nystrom
lgtm
3 years, 6 months ago (2017-06-12 23:05:59 UTC) #4
Jennifer Messerly
3 years, 6 months ago (2017-06-12 23:07:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cb038cda2f031e8ad11840a4a5eee00ed9d368c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698