Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2930203002: fix test runner to understand mutlitests that expect an error (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/dev_compiler/test/multitest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/test/browser/language_tests.js
diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js
index 23f24ec7bb97e47f2e56a5a941052ad594aa8bee..1753b322aa5d8a72a4c08263ff581749d9dd6ee7 100644
--- a/pkg/dev_compiler/test/browser/language_tests.js
+++ b/pkg/dev_compiler/test/browser/language_tests.js
@@ -93,17 +93,6 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'call_with_no_such_method_test': fail, // Function.apply not really implemented.
'canonical_const2_test': fail,
'canonical_const_test': fail,
- 'cast_test_01_multi': fail,
- 'cast_test_02_multi': fail,
- 'cast_test_03_multi': fail,
- 'cast_test_07_multi': fail,
- 'cast_test_08_multi': fail, // (oc as dynamic).bar; /// 08: runtime error
- 'cast_test_10_multi': fail,
- 'cast_test_12_multi': fail,
- 'cast_test_13_multi': fail,
- 'cast_test_14_multi': fail,
- 'cast_test_15_multi': fail,
- 'code_after_try_is_executed_test_01_multi': fail,
'compile_time_constant10_test_none_multi': fail,
'compile_time_constant_a_test': fail,
'compile_time_constant_b_test': fail,
@@ -129,6 +118,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
// Deferred libraries are not actually deferred. These tests all test
// that synchronous access to the library fails.
'deferred_call_empty_before_load_test': fail,
+ 'deferred_load_library_wrong_args_test_01_multi': fail,
'deferred_not_loaded_check_test': fail,
'deferred_redirecting_factory_test': fail,
'deferred_static_seperate_test': fail,
@@ -139,15 +129,16 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'execute_finally6_test': fail,
'expect_test': fail,
'extends_test_lib': fail,
- 'external_test_10_multi': fail,
- 'external_test_13_multi': fail,
- 'external_test_20_multi': fail,
'f_bounded_quantification3_test': fail,
'field_increment_bailout_test': fail,
'field_optimization3_test': fail,
- 'field_type_check2_test_01_multi': fail, // 01: dynamic type error
- 'final_syntax_test_08_multi': fail,
'first_class_types_test': fail,
+ 'flatten_test_01_multi': fail,
+ 'flatten_test_04_multi': fail,
+ 'flatten_test_05_multi': fail,
+ 'flatten_test_08_multi': fail,
+ 'flatten_test_09_multi': fail,
+ 'flatten_test_12_multi': fail,
'for_variable_capture_test': is.firefox('<=50') ? pass : fail,
'function_subtype_named1_test': fail,
'function_subtype_named2_test': fail,
@@ -160,10 +151,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'generic_instanceof_test': fail, // runtime strong mode reject
'generic_instanceof2_test': fail,
'generic_is_check_test': fail,
- 'generic_methods_dynamic_test_02_multi': fail,
- 'generic_methods_dynamic_test_04_multi': fail,
- 'generic_methods_recursive_bound_test_03_multi': fail,
- 'generic_methods_simple_as_expression_test_02_multi': fail,
+ 'generic_methods_bounds_test_02_multi': fail,
'generic_methods_generic_class_tearoff_test': fail,
'getter_closure_execution_order_test': fail,
'gc_test': 'slow',
@@ -176,13 +164,13 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'instanceof4_test_01_multi': fail,
'instanceof4_test_none_multi': fail,
'integer_division_by_zero_test': fail,
- 'issue_22780_test_01_multi': fail,
'issue23244_test': fail,
'lazy_static3_test': fail,
'least_upper_bound_expansive_test_none_multi': fail,
'left_shift_test': fail,
'list_is_test': fail,
'list_literal3_test': fail,
+ 'main_test_03_multi': fail,
'many_generic_instanceof_test': fail,
'many_named_arguments_test': whitelist,
'map_literal10_test': fail,
@@ -206,7 +194,6 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'regress_22445_test': fail,
'regress_22666_test': fail,
'regress_22777_test': flaky,
- 'setter_no_getter_test_01_multi': fail,
'stack_overflow_stacktrace_test': fail,
'stack_overflow_test': fail,
'stacktrace_test': chrome_fail,
@@ -216,22 +203,21 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'switch_try_catch_test': fail,
'throwing_lazy_variable_test': fail,
'truncdiv_test': fail, // did not throw
+ 'try_catch_on_syntax_test_10_multi': fail,
+ 'try_catch_on_syntax_test_11_multi': fail,
'type_variable_nested_test': fail,
'bit_operations_test_01_multi': fail,
'bit_operations_test_02_multi': fail,
'bit_operations_test_03_multi': fail,
'bit_operations_test_04_multi': fail,
- 'bool_condition_check_test_01_multi': fail,
'deferred_load_constants_test_none_multi': fail,
'external_test_21_multi': fail,
'external_test_24_multi': fail,
- 'main_not_a_function_test_01_multi': fail,
'multiline_newline_test_04_multi': fail,
'multiline_newline_test_05_multi': fail,
'multiline_newline_test_06_multi': fail,
'multiline_newline_test_none_multi': fail,
- 'no_main_test_01_multi': fail,
// https://github.com/dart-lang/sdk/issues/26124
'prefix10_negative_test': fail,
@@ -265,7 +251,6 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'growable_list_test': fail,
'hash_map2_test': skip_timeout,
'hash_set_test_01_multi': fail,
- 'hidden_library2_test_01_multi': fail,
'int_modulo_arith_test_bignum_multi': fail,
'int_modulo_arith_test_modPow_multi': fail,
'int_modulo_arith_test_none_multi': fail,
@@ -295,7 +280,6 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'reg_exp_all_matches_test': whitelist,
'reg_exp_start_end_test': whitelist,
'regress_r21715_test': fail,
- 'throw_half_surrogate_pair_test_02_multi': fail,
'sort_test': whitelist,
'splay_tree_from_iterable_test': is.firefox('<=50') ? fail : pass,
'string_case_test_01_multi': firefox_fail,
@@ -307,7 +291,6 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'symbol_reserved_word_test_06_multi': fail,
'symbol_reserved_word_test_09_multi': fail,
'symbol_reserved_word_test_12_multi': fail,
- 'throw_half_surrogate_pair_test_01_multi': fail,
'unicode_test': firefox_fail,
'uri_parameters_all_test': is.firefox('<=50') ? fail : pass,
// TODO(rnystrom): Times out because it tests a huge number of
@@ -334,8 +317,6 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
'future_timeout_test': async_unittest,
'multiple_timer_test': async_unittest,
'futures_test': fail,
- 'run_zoned6_test_01_multi': fail,
- 'run_zoned9_test_01_multi': fail,
'schedule_microtask2_test': async_unittest,
'schedule_microtask3_test': async_unittest,
'schedule_microtask5_test': async_unittest,
@@ -797,7 +778,8 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
// asynchronous exceptions.
let mainLibrary = require(module)[libraryName(name)];
- let negative = /negative_test/.test(name);
+ let negative = /negative_test/.test(name) ||
+ mainLibrary._expectRuntimeError;
let fail = has('fail');
let whitelist = has('whitelist');
« no previous file with comments | « no previous file | pkg/dev_compiler/test/multitest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698