Tablet WM : Swiping on system tray bubble.

ash/system/tray/system_tray.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SYSTEM_TRAY_SYSTEM_TRAY_H_
 #define ASH_SYSTEM_TRAY_SYSTEM_TRAY_H_
 
 #include <map>
 #include <memory>
 #include <vector>
@@ skipping 20 matching lines @@
 class TrayNetwork;
 class TrayNightLight;
 class TrayScale;
 class TraySessionLengthLimit;
 class TraySupervisedUser;
 class TraySystemInfo;
 class TrayTiles;
 class TrayUpdate;
 class WebNotificationTray;
 
+// The threshold of the velocity of the fling event.
+const float kFlingVelocity = 100.0f;

[tdanderson, 2017/06/22 20:21:43]

as-is, this constant is being exposed to the entire ash namespace. Instead
consider placing inside the SystemTray class. Have a look at 'static const int
kDesktopBorderSize' in ash/wm/window_positioner.h as an example.

[minch1, 2017/06/23 22:39:57]

Done.

+
 // There are different methods for creating bubble views.
 enum BubbleCreationType {
   BUBBLE_CREATE_NEW,    // Closes any existing bubble and creates a new one.
   BUBBLE_USE_EXISTING,  // Uses any existing bubble, or creates a new one.
 };
 
 class ASH_EXPORT SystemTray : public TrayBackgroundView,
                               public views::TrayBubbleView::Delegate {
  public:
   explicit SystemTray(Shelf* shelf);
@@ skipping 84 matching lines @@
   void OnMouseExitedView() override;
   base::string16 GetAccessibleNameForBubble() override;
   void HideBubble(const views::TrayBubbleView* bubble_view) override;
 
   ScreenTrayItem* GetScreenShareItem() { return screen_share_tray_item_; }
   ScreenTrayItem* GetScreenCaptureItem() { return screen_capture_tray_item_; }
 
   // Activates the system tray bubble.
   void ActivateBubble();
 
+  // ui::EventHandler:
+  void OnGestureEvent(ui::GestureEvent* event) override;
+
+  gfx::Rect GetWorkAreaBoundsInScreen() const;
+
  private:
   friend class SystemTrayTestApi;
   class ActivationObserver;
 
   // Closes the bubble. Used to bind as a KeyEventWatcher::KeyEventCallback.
   void CloseBubble(const ui::KeyEvent& key_event);
 
   // Activates the bubble and starts key navigation with the |key_event|.
   void ActivateAndStartNavigation(const ui::KeyEvent& key_event);
 
@@ skipping 31 matching lines @@
   // Deactivate the system tray in the shelf if it was active before.
   void CloseSystemBubbleAndDeactivateSystemTray();
 
   // Records UMA metrics for the number of user-visible rows in the system menu
   // and the percentage of the work area height covered by the system menu.
   void RecordSystemMenuMetrics();
 
   // Overridden from ActionableView.
   bool PerformAction(const ui::Event& event) override;
 
+  // Gesture related functions:
+  bool ProcessGestureEvent(const ui::GestureEvent& event);
+  bool StartGestureDrag(const ui::GestureEvent& gesture);
+  void UpdateGestureDrag(const ui::GestureEvent& gesture);
+  void CompleteGestureDrag(const ui::GestureEvent& gesture);
+
+  // Update the bounds of the system tray bubble according to the location.

[tdanderson, 2017/06/22 20:21:42]

nit: also specify that |location| is in the local coordinate space of |this|.

[minch1, 2017/06/23 22:39:57]

Done.

+  void SetBubbleBounds(gfx::Point* location);
+
+  // Return true if the system bubble should be shown (i.e., animated upward to
+  // be made fully visible) after a sequence of scroll events terminated by
+  // |sequence_end|. Otherwise return false, indicating that the
+  // partially-visible system bubble should be animated downward and made fully
+  // hidden.
+  bool ShouldShowSystemBubbleAfterScrollSequence(
+      const ui::GestureEvent& gesture);
+
+  // Shelf the system tray is in.
+  Shelf* const shelf_;
+
+  // The original bounds of the system tray bubble.
+  gfx::Rect system_tray_bubble_bounds_;
+
+  // Tracks the amount of the drag.
+  float gesture_drag_amount_ = 0.f;
+
   // The web notification tray view that appears adjacent to this view.
   WebNotificationTray* web_notification_tray_ = nullptr;
 
   // Items.
   std::vector<std::unique_ptr<SystemTrayItem>> items_;
 
   // Pointers to members of |items_|.
   SystemTrayItem* detailed_item_ = nullptr;
 
   // Bubble for default and detailed views.
@@ skipping 29 matching lines @@
   std::unique_ptr<KeyEventWatcher> key_event_watcher_;
 
   std::unique_ptr<ActivationObserver> activation_observer_;
 
   DISALLOW_COPY_AND_ASSIGN(SystemTray);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SYSTEM_TRAY_SYSTEM_TRAY_H_