Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2930093002: Complain about external methods with a body. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -18 lines) Patch
M pkg/front_end/lib/src/fasta/builder/member_builder.dart View 2 chunks +12 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 2 chunks +14 lines, -3 lines 1 comment Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_kernel.status View 2 chunks +1 line, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
ahe
https://codereview.chromium.org/2930093002/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/2930093002/diff/1/runtime/tests/vm/vm.status#newcode286 runtime/tests/vm/vm.status:286: cc/Dart_LoadLibraryPatch_Error3: Fail These errors are new, the changes above ...
3 years, 6 months ago (2017-06-09 20:12:56 UTC) #2
Paul Berry
lgtm
3 years, 6 months ago (2017-06-09 20:35:29 UTC) #3
ahe
3 years, 6 months ago (2017-06-10 08:13:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96e494d534da225fd1b5f90a5b56913a4a303b25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698