pkg/front_end/lib/src/fasta/kernel/body_builder.dart - Issue 2930093002: Complain about external methods with a body.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2930093002: Complain about external methods with a body. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart

index 08211e9a64dbe5fbddaebff2da66286607f3ff04..109b0c7fe922e5f0b49c9ab8647398aca7f7a4a1 100644

--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -484,7 +484,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {

initializer = buildInvalidInitializer(node, token.charOffset);

}

_typeInferrer.inferInitializer(initializer);

- if (member is KernelConstructorBuilder) {

+ if (member is KernelConstructorBuilder && !member.isExternal) {

member.addInitializer(initializer);

} else {

addCompileTimeError(