Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2930063002: Ensure TemplateUrlService is loaded in SearchActivity. (Closed)

Created:
3 years, 6 months ago by Ted C
Modified:
3 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure TemplateUrlService is loaded in SearchActivity. For getSearchEnginePromoShowType to be accurate the TemplateUrlService needs to be loaded (otherwise it is not possible to correctly determine the current default search engine). This adds a helper function that runs an action when the template url service is loaded and reduces the boiler plate code we had to do that in three different places. BUG=730776 Review-Url: https://codereview.chromium.org/2930063002 Cr-Commit-Position: refs/heads/master@{#478716} Committed: https://chromium.googlesource.com/chromium/src/+/1a2050d4128d8a48d69daac4281db9e184c74696

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -41 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 1 chunk +7 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 1 chunk +13 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java View 3 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Ted C
PTAL
3 years, 6 months ago (2017-06-09 17:18:33 UTC) #2
Yusuf
lgtm
3 years, 6 months ago (2017-06-12 17:29:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930063002/40001
3 years, 6 months ago (2017-06-12 18:19:31 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 19:27:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1a2050d4128d8a48d69daac4281d...

Powered by Google App Engine
This is Rietveld 408576698