Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2929893002: Fix gn get_label_info comment (Closed)

Created:
3 years, 6 months ago by F
Modified:
3 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn get_label_info comment Review-Url: https://codereview.chromium.org/2929893002 Cr-Commit-Position: refs/heads/master@{#478042} Committed: https://chromium.googlesource.com/chromium/src/+/f8bf5083fb27aa1b7c5786854f62da9b5b5532f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/function_get_label_info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
F
Hi Brett, PTAL. Thanks!
3 years, 6 months ago (2017-06-08 18:33:26 UTC) #2
brettw
lgtm
3 years, 6 months ago (2017-06-08 18:36:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929893002/1
3 years, 6 months ago (2017-06-08 18:42:58 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 18:59:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f8bf5083fb27aa1b7c5786854f62...

Powered by Google App Engine
This is Rietveld 408576698