Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2929843003: Disable USB chooser dialog while in VR (Closed)

Created:
3 years, 6 months ago by asimjour1
Modified:
3 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews, juncai+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable USB chooser dialog while in VR This change disabled display of the USB chooser dialog while in VR. BUG=730850 Review-Url: https://codereview.chromium.org/2929843003 Cr-Commit-Position: refs/heads/master@{#478300} Committed: https://chromium.googlesource.com/chromium/src/+/38457020a246e742a96765b4527e6b77a81c1e4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/ui/android/usb_chooser_dialog_android.cc View 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
asimjour1
PTAL
3 years, 6 months ago (2017-06-08 19:25:16 UTC) #6
Ted C
lgtm
3 years, 6 months ago (2017-06-08 23:25:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929843003/1
3 years, 6 months ago (2017-06-09 16:24:12 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 16:38:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/38457020a246e742a96765b4527e...

Powered by Google App Engine
This is Rietveld 408576698