PPC/s390: [compiler] Delay allocation of code-embedded heap numbers.

PPC/s390: [compiler] Delay allocation of code-embedded heap numbers.

Port 659e8f7b5cd318dd486f6853c4da47a9a8587aa6

Original Commit Message:

    Instead of allocating and embedding certain heap numbers into the code
    during code assembly, emit dummies but record the allocation requests.
    Later then, in Assembler::GetCode, allocate the heap numbers and patch
    the code by replacing the dummies with the actual objects. The
    RelocInfos for the embedded objects are already recorded correctly when
    emitting the dummies.

R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=v8:6048
LOG=N

Review-Url: https://codereview.chromium.org/2929843002
Cr-Commit-Position: refs/heads/master@{#45793}
Committed: https://chromium.googlesource.com/v8/v8/+/ae947e26fe1a8c5ff490af93922f81c38f765f6f

[JaideepBajwa, 2017-06-08 15:49:20]

lgtm

[Sampson, 2017-06-08 16:39:45]

The CQ bit was checked by sampsong@ca.ibm.com

[Sampson, 2017-06-08 16:39:46]

The patchset sent to the CQ was uploaded after l-g-t-m from bjaideep@ca.ibm.com
Link to the patchset: https://codereview.chromium.org/2929843002/#ps20001
(title: "missing codegen changes")

[commit-bot: I haz the power, 2017-06-08 16:39:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 16:42:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 16:42:40]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/42637)

[john.yan, 2017-06-08 17:22:58]

lgtm

[Sampson, 2017-06-08 17:40:13]

The CQ bit was checked by sampsong@ca.ibm.com

[commit-bot: I haz the power, 2017-06-08 17:40:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 17:41:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496943613817620,
"parent_rev": "e34f8021328d24fb92a0699a5c01c4e81af238a6", "commit_rev":
"ae947e26fe1a8c5ff490af93922f81c38f765f6f"}

[commit-bot: I haz the power, 2017-06-08 17:42:04]

Description was changed from

==========
PPC/s390: [compiler] Delay allocation of code-embedded heap numbers.

Port 659e8f7b5cd318dd486f6853c4da47a9a8587aa6

Original Commit Message:

    Instead of allocating and embedding certain heap numbers into the code
    during code assembly, emit dummies but record the allocation requests.
    Later then, in Assembler::GetCode, allocate the heap numbers and patch
    the code by replacing the dummies with the actual objects. The
    RelocInfos for the embedded objects are already recorded correctly when
    emitting the dummies.

R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com,
michael_dawson@ca.ibm.com
BUG=v8:6048
LOG=N
==========

to

==========
PPC/s390: [compiler] Delay allocation of code-embedded heap numbers.

Port 659e8f7b5cd318dd486f6853c4da47a9a8587aa6

Original Commit Message:

    Instead of allocating and embedding certain heap numbers into the code
    during code assembly, emit dummies but record the allocation requests.
    Later then, in Assembler::GetCode, allocate the heap numbers and patch
    the code by replacing the dummies with the actual objects. The
    RelocInfos for the embedded objects are already recorded correctly when
    emitting the dummies.

R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com,
michael_dawson@ca.ibm.com
BUG=v8:6048
LOG=N

Review-Url: https://codereview.chromium.org/2929843002
Cr-Commit-Position: refs/heads/master@{#45793}
Committed:
https://chromium.googlesource.com/v8/v8/+/ae947e26fe1a8c5ff490af93922f81c38f7...
==========

[commit-bot: I haz the power, 2017-06-08 17:42:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/ae947e26fe1a8c5ff490af93922f81c38f7...

[neis, 2017-06-12 09:37:54]

For the record: Excluding the other changes (see
https://codereview.chromium.org/2921473003/) is fine for now, but things will
break once I move the bulk of TF code generation to a background thread.

[Sampson, 2017-06-12 14:33:28]

On 2017/06/12 09:37:54, neis wrote:
> For the record: Excluding the other changes (see
> https://codereview.chromium.org/2921473003/) is fine for now, but things will
> break once I move the bulk of TF code generation to a background thread.

Those changes was causing some problems and I haven't figure out the cause yet.
Do you remember why mips also excluded those changes? What is missing in the
implementation?

[neis, 2017-06-13 09:58:45]

On 2017/06/12 14:33:28, Sampson wrote:
> On 2017/06/12 09:37:54, neis wrote:
> > For the record: Excluding the other changes (see
> > https://codereview.chromium.org/2921473003/) is fine for now, but things
will
> > break once I move the bulk of TF code generation to a background thread.
> 
> Those changes was causing some problems and I haven't figure out the cause
yet.

Ok, let me know if I can help.

> Do you remember why mips also excluded those changes? What is missing in the
> implementation?

They just haven't been ported yet.

[neis, 2017-07-13 09:44:51]

On 2017/06/13 09:58:45, neis wrote:
> On 2017/06/12 14:33:28, Sampson wrote:
> > On 2017/06/12 09:37:54, neis wrote:
> > > For the record: Excluding the other changes (see
> > > https://codereview.chromium.org/2921473003/) is fine for now, but things
> will
> > > break once I move the bulk of TF code generation to a background thread.
> > 
> > Those changes was causing some problems and I haven't figure out the cause
> yet.
> 
> Ok, let me know if I can help.
> 
> > Do you remember why mips also excluded those changes? What is missing in the
> > implementation?
> 
> They just haven't been ported yet.

In the meantime they have been ported to MIPS in
https://chromium-review.googlesource.com/558294, together with the "Delay
allocation of code stubs" changes. Other MIPS ports of changes that are also
still missing on PPC/S390 (as far as I can tell) are the following:

https://chromium-review.googlesource.com/565400
https://chromium-review.googlesource.com/565568
https://chromium-review.googlesource.com/566834
https://chromium-review.googlesource.com/566837

Best,
 Georg