Issue 292983007: Mojo: Make PlatformChannelRecvmsg() append handles to a deque instead.

Issue 292983007: Mojo: Make PlatformChannelRecvmsg() append handles to a deque instead. (Closed)

Created:
6 years, 7 months ago by viettrungluu

Modified:
6 years, 7 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Make PlatformChannelRecvmsg() append handles to a deque instead. This is part 1 (of N) of my rearranging things to make passing FDs actually work correctly. R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271849

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -65 lines)			Patch
M	mojo/embedder/platform_channel_pair_posix_unittest.cc	View		5 chunks	+20 lines, -19 lines	0 comments	Download
M	mojo/embedder/platform_channel_utils_posix.h	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download
M	mojo/embedder/platform_channel_utils_posix.cc	View		2 chunks	+4 lines, -6 lines	0 comments	Download
A	mojo/embedder/platform_handle_utils.h	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	mojo/embedder/platform_handle_vector.h	View		2 chunks	+2 lines, -4 lines	0 comments	Download
D	mojo/embedder/platform_handle_vector.cc	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	mojo/mojo.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/raw_channel_posix.cc	View		5 chunks	+29 lines, -11 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

yzshen1

LGTM https://codereview.chromium.org/292983007/diff/1/mojo/embedder/platform_channel_utils_posix.h File mojo/embedder/platform_channel_utils_posix.h (right): https://codereview.chromium.org/292983007/diff/1/mojo/embedder/platform_channel_utils_posix.h#newcode50 mojo/embedder/platform_channel_utils_posix.h:50: // (in the control message) to |PlatformHandle|s (and ...

6 years, 7 months ago (2014-05-20 21:09:46 UTC) #2

viettrungluu

The CQ bit was unchecked by viettrungluu@chromium.org

6 years, 7 months ago (2014-05-20 21:17:28 UTC) #4

viettrungluu

Thanks. https://codereview.chromium.org/292983007/diff/1/mojo/embedder/platform_channel_utils_posix.h File mojo/embedder/platform_channel_utils_posix.h (right): https://codereview.chromium.org/292983007/diff/1/mojo/embedder/platform_channel_utils_posix.h#newcode50 mojo/embedder/platform_channel_utils_posix.h:50: // (in the control message) to |PlatformHandle|s (and ...

6 years, 7 months ago (2014-05-20 21:17:36 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/292983007/20001

6 years, 7 months ago (2014-05-20 21:19:08 UTC) #7

Message was sent while issue was closed.

Change committed as 271849

Expand Messages | Collapse Messages