Mojo: Make PlatformChannelRecvmsg() append handles to a deque instead.

mojo/embedder/platform_channel_utils_posix.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_EMBEDDER_PLATFORM_CHANNEL_UTILS_POSIX_H_
 #define MOJO_EMBEDDER_PLATFORM_CHANNEL_UTILS_POSIX_H_
 
 #include <stddef.h>
 #include <sys/types.h>  // For |ssize_t|.
 
-#include <vector>
+#include <deque>
 
 #include "base/memory/scoped_ptr.h"
 #include "mojo/embedder/platform_handle.h"
-#include "mojo/embedder/platform_handle_vector.h"
 #include "mojo/system/system_impl_export.h"
 
 struct iovec;  // Declared in <sys/uio.h>.
 
 namespace mojo {
 namespace embedder {
 
 // The maximum number of handles that can be sent "at once" using
 // |PlatformChannelSendHandles()|.
 // TODO(vtl): This number is taken from ipc/file_descriptor_set_posix.h:
@@ skipping 15 matching lines @@
 // (e.g., created using PlatformChannelPair|). (These will be sent in a single
 // message having one null byte of data and one control message header with all
 // the file descriptors.) All of the handles must be valid, and there must be at
 // most |kPlatformChannelMaxNumHandles| (and at least one handle). Returns true
 // on success, in which case it closes all the handles.
 MOJO_SYSTEM_IMPL_EXPORT bool PlatformChannelSendHandles(PlatformHandle h,
                                                         PlatformHandle* handles,
                                                         size_t num_handles);
 
 // Wrapper around |recvmsg()|, which will extract any attached file descriptors
-// (in the control message) to |PlatformHandle|s. (This also handles |EINTR|.)
-// If |*handles| is null and handles are received, a vector will be allocated;
-// otherwise, any handles received will be appended to the existing vector.
+// (in the control message) to |PlatformHandle|s (and appended to

[yzshen1, 2014/05/20 21:09:46]

nit: appended -> append them?

[viettrungluu, 2014/05/20 21:17:36]

Done.

+// |platform_handles|). (This also handles |EINTR|.)
 MOJO_SYSTEM_IMPL_EXPORT ssize_t PlatformChannelRecvmsg(
     PlatformHandle h,
     void* buf,
     size_t num_bytes,
-    ScopedPlatformHandleVectorPtr* handles);
+    std::deque<PlatformHandle>* platform_handles);
 
 }  // namespace embedder
 }  // namespace mojo
 
 #endif  // MOJO_EMBEDDER_PLATFORM_CHANNEL_UTILS_POSIX_H_