Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2929733003: MacViews: Wire up CreateChromeApplicationShortcutView

Created:
3 years, 6 months ago by tapted
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, tfarina, srahim+watch_chromium.org, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Wire up CreateChromeApplicationShortcutView This dialog is shown on chrome://apps when creating shortcuts for Chrome Apps. Wire up the toolkit-views version on Mac, which shows as a window-modal dialog (rather than an app-modal NSAlert). Rename `menu_check_box_` to `applications_check_box_`. It's used for - Start Page/Menu on Win - Applications Menu on Linux - Applications folder on Mac. Basically, the place where applications go. BUG=728153

Patch Set 1 #

Patch Set 2 : rename ivar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -43 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_dialogs_views_mac.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm View 3 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 10 chunks +44 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-08 05:11:00 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929733003/1
3 years, 6 months ago (2017-06-08 05:11:17 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-08 06:46:28 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 6 months ago (2017-06-08 06:46:29 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-08 07:14:11 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929733003/20001
3 years, 6 months ago (2017-06-08 07:14:21 UTC) #6
tapted
Description was changed from ========== MacViews: Wire up CreateChromeApplicationShortcutView BUG=728153 ========== to ========== MacViews: Wire ...
3 years, 6 months ago (2017-06-08 07:19:47 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-08 08:36:59 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 08:37:00 UTC) #9 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698