Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2929733002: Fix build break when building with enable_openvr=true on Windows (Closed)

Created:
3 years, 6 months ago by billorr
Modified:
3 years, 6 months ago
Reviewers:
bajones
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build break when building with enable_openvr=true on Windows BUG=730436 Review-Url: https://codereview.chromium.org/2929733002 Cr-Commit-Position: refs/heads/master@{#477907} Committed: https://chromium.googlesource.com/chromium/src/+/d607aacd7fd54bab7abeef5b20eea1f4bf26e674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M device/vr/openvr/openvr_device.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/vr/openvr/openvr_device.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/openvr/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
billorr
3 years, 6 months ago (2017-06-08 04:24:03 UTC) #2
billorr
On 2017/06/08 04:24:03, billorr wrote: bajones@, please review this change.
3 years, 6 months ago (2017-06-08 04:24:22 UTC) #3
bajones
LGTM
3 years, 6 months ago (2017-06-08 04:44:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929733002/1
3 years, 6 months ago (2017-06-08 04:47:02 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 06:02:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d607aacd7fd54bab7abeef5b20ee...

Powered by Google App Engine
This is Rietveld 408576698