Issue 292973007: DevTools: Focus/blur events that are triggered by DevTools get dispatched when page is unfocused

Issue 292973007: DevTools: Focus/blur events that are triggered by DevTools get dispatched when page is unfocused (Closed)

Created:
6 years, 7 months ago by pfeldman

Modified:
6 years, 7 months ago

Reviewers:
vsevik, dgozman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Focus/blur events that are triggered by DevTools get dispatched when page is unfocused BUG=375889 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174628

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -0 lines)			Patch
A	LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html	View	1	1 chunk	+79 lines, -0 lines	2 comments	Download
A	LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus-expected.txt	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	Source/core/testing/Internals.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/core/testing/Internals.idl	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/web/WebDevToolsAgentImpl.cpp	View		3 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dgozman

lgtm https://codereview.chromium.org/292973007/diff/20001/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html File LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html (right): https://codereview.chromium.org/292973007/diff/20001/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html#newcode18 LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html:18: window.internals.setFocused(true); Events you dispatch should have already focused ...

6 years, 7 months ago (2014-05-22 12:45:46 UTC) #2

vsevik

lgtm https://chromiumcodereview.appspot.com/292973007/diff/20001/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html File LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html (right): https://chromiumcodereview.appspot.com/292973007/diff/20001/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html#newcode18 LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html:18: window.internals.setFocused(true); On 2014/05/22 12:45:47, dgozman wrote: > Events ...

6 years, 7 months ago (2014-05-22 13:14:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/292973007/20001

6 years, 7 months ago (2014-05-22 17:34:02 UTC) #5

Message was sent while issue was closed.

Change committed as 174628

Expand Messages | Collapse Messages