Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Unified Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 292973007: DevTools: Focus/blur events that are triggered by DevTools get dispatched when page is unfocused (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebDevToolsAgentImpl.cpp
diff --git a/Source/web/WebDevToolsAgentImpl.cpp b/Source/web/WebDevToolsAgentImpl.cpp
index 83c2b9c78992e2bd5213d44cdf212be3483046f7..413dbe2b24f4da2419ef1c30c51448eb6cbb5a6c 100644
--- a/Source/web/WebDevToolsAgentImpl.cpp
+++ b/Source/web/WebDevToolsAgentImpl.cpp
@@ -44,6 +44,7 @@
#include "core/frame/Settings.h"
#include "core/inspector/InjectedScriptHost.h"
#include "core/inspector/InspectorController.h"
+#include "core/page/FocusController.h"
#include "core/page/Page.h"
#include "core/rendering/RenderView.h"
#include "platform/JSONValues.h"
@@ -580,6 +581,9 @@ void WebDevToolsAgentImpl::processGPUEvent(const GPUEvent& event)
void WebDevToolsAgentImpl::dispatchKeyEvent(const PlatformKeyboardEvent& event)
{
+ if (!m_webViewImpl->page()->focusController().isFocused())
+ m_webViewImpl->setFocus(true);
+
m_generatingEvent = true;
WebKeyboardEvent webEvent = WebKeyboardEventBuilder(event);
if (!webEvent.keyIdentifier[0] && webEvent.type != WebInputEvent::Char)
@@ -590,6 +594,9 @@ void WebDevToolsAgentImpl::dispatchKeyEvent(const PlatformKeyboardEvent& event)
void WebDevToolsAgentImpl::dispatchMouseEvent(const PlatformMouseEvent& event)
{
+ if (!m_webViewImpl->page()->focusController().isFocused())
+ m_webViewImpl->setFocus(true);
+
m_generatingEvent = true;
WebMouseEvent webEvent = WebMouseEventBuilder(m_webViewImpl->mainFrameImpl()->frameView(), event);
m_webViewImpl->handleInputEvent(webEvent);

Powered by Google App Engine
This is Rietveld 408576698