|
|
Created:
3 years, 6 months ago by Ilya Sherman Modified:
3 years, 6 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Cleanup] Transition NetworkTime browser tests to use a ScopedFeatureList.
BUG=727044
TEST=browser_tests --gtest_filter=NetworkTimePolicyTest.*
Review-Url: https://codereview.chromium.org/2929713002
Cr-Commit-Position: refs/heads/master@{#478493}
Committed: https://chromium.googlesource.com/chromium/src/+/9fb15b84bfb031527e6875b0c73c5e8ee3a76401
Patch Set 1 #Patch Set 2 : Update SSLNetworkTimeBrowserTest as well #
Messages
Total messages: 25 (15 generated)
The CQ bit was checked by isherman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm
isherman@chromium.org changed reviewers: + tnagel@chromium.org
Thiemo, PTAL for OWNERS approval. Thanks!
Nit: Ilya, can you also add SSLNetworkTimeBrowserTest to this patch?
lgtm
Description was changed from ========== [Cleanup] Transition the NetworkTimePolicyTest to use a ScopedFeatureList. BUG=727044 TEST=browser_tests --gtest_filter=NetworkTimePolicyTest.* R=chaopeng@chromium.org ========== to ========== [Cleanup] Transition NetworkTime browser tests to use a ScopedFeatureList. BUG=727044 TEST=browser_tests --gtest_filter=NetworkTimePolicyTest.* ==========
The CQ bit was checked by isherman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
isherman@chromium.org changed reviewers: + estark@chromium.org
+Emily for SSL test changes On 2017/06/09 03:29:38, chaopeng wrote: > Nit: Ilya, can you also add SSLNetworkTimeBrowserTest to this patch? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks! lgtm
The CQ bit was checked by isherman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tnagel@chromium.org, chaopeng@chromium.org Link to the patchset: https://codereview.chromium.org/2929713002/#ps20001 (title: "Update SSLNetworkTimeBrowserTest as well")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497057932568610, "parent_rev": "978464a97d85014ca4414366789702be3b35fa15", "commit_rev": "9fb15b84bfb031527e6875b0c73c5e8ee3a76401"}
Message was sent while issue was closed.
Description was changed from ========== [Cleanup] Transition NetworkTime browser tests to use a ScopedFeatureList. BUG=727044 TEST=browser_tests --gtest_filter=NetworkTimePolicyTest.* ========== to ========== [Cleanup] Transition NetworkTime browser tests to use a ScopedFeatureList. BUG=727044 TEST=browser_tests --gtest_filter=NetworkTimePolicyTest.* Review-Url: https://codereview.chromium.org/2929713002 Cr-Commit-Position: refs/heads/master@{#478493} Committed: https://chromium.googlesource.com/chromium/src/+/9fb15b84bfb031527e6875b0c73c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9fb15b84bfb031527e6875b0c73c... |