Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2929713002: [Cleanup] Transition NetworkTime browser tests to use a ScopedFeatureList. (Closed)

Created:
3 years, 6 months ago by Ilya Sherman
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Transition NetworkTime browser tests to use a ScopedFeatureList. BUG=727044 TEST=browser_tests --gtest_filter=NetworkTimePolicyTest.* Review-Url: https://codereview.chromium.org/2929713002 Cr-Commit-Position: refs/heads/master@{#478493} Committed: https://chromium.googlesource.com/chromium/src/+/9fb15b84bfb031527e6875b0c73c5e8ee3a76401

Patch Set 1 #

Patch Set 2 : Update SSLNetworkTimeBrowserTest as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M chrome/browser/policy/policy_browsertest.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
Ilya Sherman
3 years, 6 months ago (2017-06-08 01:40:44 UTC) #1
chaopeng
lgtm
3 years, 6 months ago (2017-06-08 14:15:28 UTC) #6
chaopeng
lgtm
3 years, 6 months ago (2017-06-08 14:15:30 UTC) #7
Ilya Sherman
Thiemo, PTAL for OWNERS approval. Thanks!
3 years, 6 months ago (2017-06-08 18:00:02 UTC) #9
chaopeng
Nit: Ilya, can you also add SSLNetworkTimeBrowserTest to this patch?
3 years, 6 months ago (2017-06-09 03:29:38 UTC) #10
Thiemo Nagel
lgtm
3 years, 6 months ago (2017-06-09 08:33:02 UTC) #11
Ilya Sherman
+Emily for SSL test changes On 2017/06/09 03:29:38, chaopeng wrote: > Nit: Ilya, can you ...
3 years, 6 months ago (2017-06-09 20:29:23 UTC) #16
estark
Thanks! lgtm
3 years, 6 months ago (2017-06-10 01:08:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929713002/20001
3 years, 6 months ago (2017-06-10 01:25:49 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-06-10 01:30:52 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9fb15b84bfb031527e6875b0c73c...

Powered by Google App Engine
This is Rietveld 408576698