Issue 2929703003: NetInfo: Slight update to the default network quality value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2929703003: NetInfo: Slight update to the default network quality value (Closed)

Created:
3 years, 6 months ago by tbansal1

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews, haraken, jam, blink-reviews, darin-cc_chromium.org, jkarlin+watch_chromium.org

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

NetInfo: Slight update to the default network quality value This CL changes the default values of |downlink| to be a multiple of 25 kbps. BUG=727786 Review-Url: https://codereview.chromium.org/2912013002 Cr-Original-Commit-Position: refs/heads/master@{#477227} Review-Url: https://codereview.chromium.org/2929703003 . Cr-Commit-Position: refs/branch-heads/3112@{#270} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/22922b662424d54269fdcb2625622b9f842bb627

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -19 lines)			Patch
M	content/browser/net_info_browsertest.cc	View	12 chunks	+34 lines, -13 lines	0 comments	Download
M	content/test/data/net_info.html	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

tbansal1

3 years, 6 months ago (2017-06-08 22:10:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
22922b662424d54269fdcb2625622b9f842bb627.