Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2929703002: [api] Regenerate remote APIs. (Closed)

Created:
3 years, 6 months ago by dnj
Modified:
3 years, 6 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update code #

Total comments: 1

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -175 lines) Patch
M buildbucket/client/cmd/buildbucket/inconsistencies.go View 1 3 chunks +5 lines, -5 lines 0 comments Download
M common/api/buildbucket/buildbucket/v1/buildbucket-api.json View 8 chunks +108 lines, -72 lines 0 comments Download
M common/api/buildbucket/buildbucket/v1/buildbucket-gen.go View 10 chunks +114 lines, -88 lines 0 comments Download
M common/api/buildbucket/swarmbucket/v1/swarmbucket-api.json View 2 chunks +14 lines, -1 line 0 comments Download
M common/api/buildbucket/swarmbucket/v1/swarmbucket-gen.go View 1 chunk +6 lines, -0 lines 0 comments Download
M common/api/isolate/isolateservice/v1/isolateservice-api.json View 1 chunk +1 line, -1 line 0 comments Download
M common/api/luci_config/config/v1/config-api.json View 1 chunk +1 line, -1 line 0 comments Download
M common/api/swarming/swarming/v1/swarming-api.json View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/buildbucket/builder.go View 1 3 chunks +3 lines, -3 lines 0 comments Download
M milo/appengine/buildbucket/common.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scheduler/appengine/task/buildbucket/buildbucket.go View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
dnj
3 years, 6 months ago (2017-06-08 01:11:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929703002/1
3 years, 6 months ago (2017-06-08 01:11:32 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/369e1357fb8ce910) ...
3 years, 6 months ago (2017-06-08 01:14:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929703002/20001
3 years, 6 months ago (2017-06-08 01:19:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Mac Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/369e1aa7276f6e10)
3 years, 6 months ago (2017-06-08 01:22:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929703002/40001
3 years, 6 months ago (2017-06-08 01:24:53 UTC) #11
nodir
lgtm https://codereview.chromium.org/2929703002/diff/20001/buildbucket/client/cmd/buildbucket/inconsistencies.go File buildbucket/client/cmd/buildbucket/inconsistencies.go (right): https://codereview.chromium.org/2929703002/diff/20001/buildbucket/client/cmd/buildbucket/inconsistencies.go#newcode183 buildbucket/client/cmd/buildbucket/inconsistencies.go:183: func (r *inconsistencyRun) fetchBuilds(builder builderID, startingFrom time.Time) ([]*buildbucket.ApiCommonBuildMessage, ...
3 years, 6 months ago (2017-06-08 01:25:24 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 01:30:28 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/d022e0f977f0612035fbcf440fadd2501a029229

Powered by Google App Engine
This is Rietveld 408576698